Skip to content

Conversation

@Jhsmit
Copy link
Owner

@Jhsmit Jhsmit commented Mar 31, 2021

Major update to the web application:

  • Support of batch fitting from web app
  • controllers/figures/sources as Lumen sources
  • Classifcation control panel generates cmap and norm objects, and these can be used to color whole dataframes in batch
  • Export of full results dataframes and .pml files in batch (as .zip file)

Minor changes:

  • Allow for custom datasets names
  • Download
  • Allow removing datasets
  • Allow removing tables? (combined with table viewer)

Related issues: #157, #155, #154, #153, #151, #132, #199, #106, #99, #98, #93, #112, #92

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #188 (547367a) into master (a9eaaa9) will decrease coverage by 10.92%.
The diff coverage is 71.58%.

❗ Current head 547367a differs from pull request most recent head 1304947. Consider uploading reports for the commit 1304947 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #188       +/-   ##
===========================================
- Coverage   67.41%   56.48%   -10.93%     
===========================================
  Files          27       31        +4     
  Lines        4474     4844      +370     
===========================================
- Hits         3016     2736      -280     
- Misses       1458     2108      +650     
Impacted Files Coverage Δ
pyhdx/fileIO.py 85.54% <7.69%> (-7.93%) ⬇️
pyhdx/panel/data_sources.py 47.74% <52.83%> (-26.92%) ⬇️
pyhdx/panel/controllers.py 40.40% <56.39%> (-27.55%) ⬇️
pyhdx/panel/opts.py 60.60% <60.60%> (ø)
pyhdx/models.py 80.10% <72.72%> (-1.05%) ⬇️
pyhdx/panel/main_controllers.py 83.09% <76.08%> (-14.34%) ⬇️
pyhdx/panel/transforms.py 76.13% <76.13%> (ø)
pyhdx/panel/fig_panels.py 45.42% <81.66%> (-40.95%) ⬇️
pyhdx/panel/base.py 56.35% <88.88%> (-25.67%) ⬇️
tests/test_lumen_components.py 95.12% <95.12%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9eaaa9...1304947. Read the comment docs.

@Jhsmit
Copy link
Owner Author

Jhsmit commented May 7, 2021

fixes #157, #154, #93, #112

@Jhsmit Jhsmit merged commit 6c5ba95 into master May 7, 2021
@Jhsmit Jhsmit deleted the batch_gui branch May 7, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant