refactor(kendall-tau): drop ConvertibleToReal constraint from kendallTau#164
Merged
JimmyMAndersson merged 1 commit intoMay 11, 2026
Merged
Conversation
kendallTau only requires ordinal data — Comparable and Hashable are sufficient. All arithmetic inside the function operates on Int values derived from counts, not on T or U directly. Removing ConvertibleToReal makes the API consistent with that requirement. Also adds an ordinal-data test using non-numeric enum types to exercise the relaxed constraint. Closes #161
JimmyMAndersson
added
the
improvement
JimmyMAndersson
deleted the
refactor/161-drop-kendallstau-convertibletoreal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kendallTau only requires ordinal data — Comparable and Hashable are sufficient. All arithmetic inside the function operates on Int values derived from counts, not on T or U directly. Removing ConvertibleToReal makes the API consistent with that requirement.
Also adds an ordinal-data test using non-numeric enum types to exercise the relaxed constraint.
Closes #161