[WIP] Figure out the confict between LSPlant and LSPlt#10
Closed
JingMatrix wants to merge 4 commits into
Closed
Conversation
JingMatrix
force-pushed
the
test
branch
4 times, most recently
from
be0441e to
e2eb5db
Compare
|
@JingMatrix Please let me know when you further hone it down and I will spare some time to test for further validation as I can reproduce it, on my device over here. Thank you for your efforts! It is appreciated. |
This comment was marked as outdated.
This comment was marked as outdated.
Owner
Author
|
It turns out |
JingMatrix
force-pushed
the
master
branch
2 times, most recently
from
80e3c90 to
7a69ee2
Compare
JingMatrix
force-pushed
the
master
branch
2 times, most recently
from
6abb7c8 to
c2c4e52
Compare
JingMatrix
force-pushed
the
master
branch
2 times, most recently
from
73d639f to
99a538e
Compare
Remove ccache. Close #30 as completed.
JingMatrix
pushed a commit
that referenced
this pull request
Sep 12, 2024
build(deps): upgrade `fmt` and `lsplant` to their corresponding latest version
Avoid using unallocated address, which might cause crashes
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As shown in #9, LSPlt is not working well for some devices (but not including mine).
WRONG:
It turning out that, by reverting the update of LSPlant, LSPlt works well on those devices.In this pull-request, I am trying to figure out which commit of the LSPlant upstream is causing the problem.
Users of JingMatrix/LSPosed are welcomed to provide their test results on their devices to help me.
The goal is to ensure that the string
Dobbydoesn't appear in the log output ofadb logcat -s LSPlt LSPosed, which means that LSPlt has worked properly.LSPlt doesn't work here neither:
To start the test, please first confirm that LSPlst works with this build: https://github.com/JingMatrix/LSPosed/actions/runs/10641620655Then please check if LSPlt works for CI builds of current pull-request and upload relevant logs here.