Correctly handle null thisObject in VectorChain for static methods#658
Merged
JingMatrix merged 1 commit intomasterfrom Apr 13, 2026
Merged
Correctly handle null thisObject in VectorChain for static methods#658JingMatrix merged 1 commit intomasterfrom
JingMatrix merged 1 commit intomasterfrom
Conversation
The previous implementation used a dummy `Any()` instance as a fallback when `thisObj` was null. This incorrectly bound an object instance to static method calls and prevented the terminal handler from receiving the required null pointer. We move core progression logic into a private `internalProceed` method that accepts a nullable `thisObject`. Moreover, we update libxposed submodule to include recent documentation changes (no API changes required).
Owner
Author
JingMatrix
added a commit
that referenced
this pull request
Apr 13, 2026
We should name the arguments correctly, to not mix with private fields. Moreover, add module loading tag to `kModuleTags`.
JingMatrix
added a commit
that referenced
this pull request
Apr 13, 2026
We should name the arguments correctly, to not mix with private fields. Moreover, expand `kModuleTags` to include `VectorModuleManager`, which handles `libxposed` API module loading.
JingMatrix
added a commit
that referenced
this pull request
Apr 13, 2026
) The previous implementation used a dummy `Any()` instance as a fallback when `thisObj` was null. This incorrectly bound an object instance to static method calls and prevented the terminal handler from receiving the required null pointer. We move core progression logic into a private `internalProceed` method that accepts a nullable `thisObject`. Moreover, we update libxposed submodule to include recent documentation changes (no API changes required).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation used a dummy
Any()instance as a fallback whenthisObjwas null. This incorrectly bound an object instance to static method calls and prevented the terminal handler from receiving the required null pointer. We move core progression logic into a privateinternalProceedmethod that accepts a nullablethisObject.Moreover, we update libxposed submodule to include recent documentation changes (no API changes required).