Fix gesture preview crash on macOS 12#3
Merged
aaronkollasch merged 1 commit intomainfrom Nov 23, 2021
Merged
Conversation
[NSView lockFocus] was deprecated in macOS 10.14 and seems to be removed on 12.0 http://codeworkshop.net/objc-diff/sdkdiffs/macos/10.14/AppKit.html A static background color is a viable substitute, though not as pretty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[NSView lockFocus]was deprecated in macOS 10.14 and seems to be removed on 12.0.This PR prevents the prefpane from crashing while trying to show the gesture preview window. It uses a single background color as a substitute for a drawn background, though it is not as pretty.
imageWithSize:flipped:drawingHandleris a potential replacement forlockFocus, e.g.Pull request submitted upstream: #4