Skip to content

[Feat] 문항 후보 응답에 ID 추가#65

Merged
whc9999 merged 1 commit into
mainfrom
feat/#39-questionid
May 22, 2026
Merged

[Feat] 문항 후보 응답에 ID 추가#65
whc9999 merged 1 commit into
mainfrom
feat/#39-questionid

Conversation

@whc9999
Copy link
Copy Markdown
Collaborator

@whc9999 whc9999 commented May 22, 2026

✨ 어떤 이유로 PR를 하셨나요?

  • feature 병합
  • 버그 수정(아래에 issue #를 남겨주세요)
  • 코드 개선
  • 코드 수정
  • 배포
  • 기타(아래에 자세한 내용 기입해주세요)

📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요

  • 문항 후보 조회 응답에 questionId 필드 추가
  • 기본 문항 후보에 고정 ID 부여
  • 문항 후보 조회 테스트에 ID 검증 추가

📸 작업 화면 스크린샷

⚠️ PR하기 전에 확인해주세요

  • 로컬테스트를 진행하셨나요?
  • 머지할 브랜치를 확인하셨나요?
  • 관련 label을 선택하셨나요?

🚨 관련 이슈 번호 [#39 ]

Summary by CodeRabbit

  • New Features
    • Question candidate API responses now include unique question identifiers for improved tracking and reference capabilities.

Review Change Stack

- 문항 후보 조회 응답에 questionId 필드 추가
- 기본 문항 후보에 고정 ID 부여
- 문항 후보 조회 테스트에 ID 검증 추가
@whc9999 whc9999 merged commit 011da53 into main May 22, 2026
1 of 2 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d4a3010-677d-4786-81f4-08f9e4152fa4

📥 Commits

Reviewing files that changed from the base of the PR and between 334c06c and cba789b.

📒 Files selected for processing (3)
  • src/main/java/com/jobdri/jobdri_api/domain/analysis/dto/response/QuestionCandidateResponse.java
  • src/main/java/com/jobdri/jobdri_api/domain/analysis/service/QuestionService.java
  • src/test/java/com/jobdri/jobdri_api/domain/analysis/service/QuestionServiceTest.java

📝 Walkthrough

Walkthrough

Question candidate responses now include stable question ID identifiers. The QuestionCandidateResponse DTO record gains a questionId field; the internal QuestionCandidate model is updated to carry IDs; default candidates are initialized with IDs 1–5; and the service mapping populates the new response field. The test verifies the IDs are correct and ordered.

Changes

Question candidate ID addition

Layer / File(s) Summary
Response contract update
src/main/java/com/jobdri/jobdri_api/domain/analysis/dto/response/QuestionCandidateResponse.java
QuestionCandidateResponse record adds Long questionId component.
Service model and mapping
src/main/java/com/jobdri/jobdri_api/domain/analysis/service/QuestionService.java, src/test/java/com/jobdri/jobdri_api/domain/analysis/service/QuestionServiceTest.java
Internal QuestionCandidate record gains id field; DEFAULT_CANDIDATES initialized with IDs 1L–5L; getQuestionCandidates(...) passes candidate IDs into response objects; test assertion verifies the extracted questionId values match 1L through 5L in order.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hops through ID fields so bright,
Where candidates now carry numbers right—
From one to five, they march in line,
Responses shaped, both clean and fine,
Tests verify what should be true,
The answers bloom, all fresh and new! 🐰✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/#39-questionid

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant