Skip to content

[Fix] 재지원 공고 연결 기준 수정 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whc9999 merged 2 commits into from
May 27, 2026
Merged

[Fix] 재지원 공고 연결 기준 수정 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8645fd8
[Fix] 재지원 공고 연결 기준 수정
whc9999 May 27, 2026
956a21b
[Fix] 재지원 순번 동시성 처리 개선
whc9999 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/jobdri/jobdri_api/domain/mockapply/controller/MockApplyController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public ApiResponse<MockApplyCreateResponse> createMockApply(
}

@Operation(
summary = "모의 서류 지원 재도전 - ",
summary = "모의 서류 지원 재도전",
description = "기존 모의 서류 지원의 공고와 선택 문항을 복사해 새 회차의 모의 서류 지원을 생성합니다. 답변은 비워진 상태로 자소서 입력 단계부터 다시 진행합니다."
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

OpenAPI description is stale vs new retry behavior.

Line 203 still says the retry flow “copies” the posting, but this PR’s behavior is to create a new MockApply linked to the original JobPosting. Please update the description text to reflect reuse of the original posting.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/main/java/com/jobdri/jobdri_api/domain/mockapply/controller/MockApplyController.java`
at line 203, Update the OpenAPI description string in MockApplyController (the
description used in the `@Operation` annotation for the retry endpoint) to reflect
that the new retry creates a new MockApply linked to the original JobPosting
rather than copying the posting and selection questions; change wording from
"복사" (copy) to indicate "재사용" or "원본 공고와 연동" and that answers are cleared so the
applicant restarts from the essay input step.

)
@ApiResponses(value = {
Expand Down
15 changes: 5 additions & 10 deletions src/main/java/com/jobdri/jobdri_api/domain/mockapply/entity/MockApplySequence.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
name = "mock_apply_sequences",
uniqueConstraints = @UniqueConstraint(
name = "uk_mock_apply_sequences_key",
columnNames = {"user_id", "company_id", "detail_classification_id"}
columnNames = {"user_id", "job_posting_id"}
)
)
public class MockApplySequence {
Expand All @@ -28,25 +28,20 @@ public class MockApplySequence {
@Column(name = "user_id", nullable = false)
private Long userId;

@Column(name = "company_id", nullable = false)
private Long companyId;

@Column(name = "detail_classification_id", nullable = false)
private Long detailClassificationId;
@Column(name = "job_posting_id", nullable = false)
private Long jobPostingId;

@Column(nullable = false)
private int lastSequence;

public static MockApplySequence create(
Long userId,
Long companyId,
Long detailClassificationId,
Long jobPostingId,
int lastSequence
) {
return MockApplySequence.builder()
.userId(userId)
.companyId(companyId)
.detailClassificationId(detailClassificationId)
.jobPostingId(jobPostingId)
.lastSequence(lastSequence)
.build();
}
Expand Down
11 changes: 11 additions & 0 deletions src/main/java/com/jobdri/jobdri_api/domain/mockapply/repository/MockApplyRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ public interface MockApplyRepository extends JpaRepository<MockApply, Long> {
""")
Optional<MockApply> findByIdWithJobPosting(@Param("mockApplyId") Long mockApplyId);

@Query("""
select coalesce(max(ma.sequence), 0)
from MockApply ma
where ma.user.id = :userId
and ma.jobPosting.id = :jobPostingId
""")
int findMaxSequenceByUserIdAndJobPostingId(
@Param("userId") Long userId,
@Param("jobPostingId") Long jobPostingId
);

@Query("""
select coalesce(max(ma.sequence), 0)
from MockApply ma
Expand Down
6 changes: 2 additions & 4 deletions ...n/java/com/jobdri/jobdri_api/domain/mockapply/repository/MockApplySequenceRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,10 @@ public interface MockApplySequenceRepository extends JpaRepository<MockApplySequ
select mas
from MockApplySequence mas
where mas.userId = :userId
and mas.companyId = :companyId
and mas.detailClassificationId = :detailClassificationId
and mas.jobPostingId = :jobPostingId
""")
Optional<MockApplySequence> findByKeyForUpdate(
@Param("userId") Long userId,
@Param("companyId") Long companyId,
@Param("detailClassificationId") Long detailClassificationId
@Param("jobPostingId") Long jobPostingId
);
}
12 changes: 5 additions & 7 deletions src/main/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplySequenceService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,16 @@ public class MockApplySequenceService {
private final MockApplyRepository mockApplyRepository;

@Transactional(propagation = Propagation.REQUIRES_NEW)
public int allocate(Long userId, Long companyId, Long detailClassificationId) {
public int allocate(Long userId, Long jobPostingId) {
MockApplySequence sequence = mockApplySequenceRepository
.findByKeyForUpdate(userId, companyId, detailClassificationId)
.findByKeyForUpdate(userId, jobPostingId)
.orElseGet(() -> mockApplySequenceRepository.saveAndFlush(
MockApplySequence.create(
userId,
companyId,
detailClassificationId,
mockApplyRepository.findMaxSequenceByUserIdAndCompanyIdAndDetailClassificationId(
jobPostingId,
mockApplyRepository.findMaxSequenceByUserIdAndJobPostingId(
userId,
companyId,
detailClassificationId
jobPostingId
)
)
));
Expand Down
17 changes: 2 additions & 15 deletions src/main/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,18 +85,9 @@ public MockApplyRetryResponse retryMockApply(User user, Long mockApplyId) {
MockApply sourceMockApply = getOwnedMockApplyWithJobPosting(validatedUser, mockApplyId);
JobPosting sourceJobPosting = sourceMockApply.getJobPosting();

JobPosting clonedJobPosting = jobPostingRepository.save(JobPosting.create(
validatedUser,
sourceJobPosting.getCompany(),
sourceJobPosting.getDetailClassification(),
sourceJobPosting.getTask(),
sourceJobPosting.getRequirement(),
sourceJobPosting.getPreferred()
));

MockApply retryMockApply = saveMockApplyWithSequence(
validatedUser,
clonedJobPosting,
sourceJobPosting,
sourceMockApply.getApplyType(),
null
);
Expand Down Expand Up @@ -269,11 +260,7 @@ private int resolveSequence(User user, JobPosting jobPosting, Integer requestedS
private int allocateSequence(User user, JobPosting jobPosting) {
for (int attempt = 0; attempt < SEQUENCE_ALLOCATE_MAX_RETRY; attempt++) {
try {
return mockApplySequenceService.allocate(
user.getId(),
jobPosting.getCompany().getId(),
jobPosting.getDetailClassification().getId()
);
return mockApplySequenceService.allocate(user.getId(), jobPosting.getId());
} catch (DataIntegrityViolationException e) {
if (attempt == SEQUENCE_ALLOCATE_MAX_RETRY - 1) {
throw new GeneralException(
Expand Down
14 changes: 8 additions & 6 deletions src/test/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ void createActualApplyWithRequestedSequence() {
}

@Test
@DisplayName("같은 회사와 직무의 다른 공고로 재지원하면 다음 순번을 저장한다")
void createActualApplySequencesAcrossSameCompanyAndDetailJobPostings() {
@DisplayName("같은 회사와 직무여도 다른 공고이면 순번을 따로 계산한다")
void createActualApplySequencesByJobPosting() {
User user = saveUser("actual-apply-retry-sequence@example.com");
Company company = saveCompany("재지원 기업 " + UUID.randomUUID(), CompanySize.MEDIUM);
DetailClassification detailClassification = saveDetailClassification("백엔드 개발");
Expand All @@ -138,8 +138,8 @@ void createActualApplySequencesAcrossSameCompanyAndDetailJobPostings() {

MockApply secondMockApply = mockApplyRepository.findById(secondResponse.mockApplyId()).orElseThrow();
assertThat(firstResponse.sequence()).isEqualTo(1);
assertThat(secondResponse.sequence()).isEqualTo(2);
assertThat(secondMockApply.getSequence()).isEqualTo(2);
assertThat(secondResponse.sequence()).isEqualTo(1);
assertThat(secondMockApply.getSequence()).isEqualTo(1);
}

@Test
Expand Down Expand Up @@ -236,7 +236,7 @@ void createMockApplyFromJobPosting() {
}

@Test
@DisplayName("기존 지원의 공고와 문항을 복사해 재도전 지원을 생성한다")
@DisplayName("기존 지원의 공고에 새 회차와 문항을 생성한다")
void retryMockApply() {
User user = saveUser("retry-mock-apply@example.com");
JobPosting jobPosting = saveJobPosting(user, "백엔드 개발");
Expand All @@ -250,12 +250,14 @@ void retryMockApply() {
JobPosting retryJobPosting = jobPostingRepository.findById(response.jobPostingId()).orElseThrow();
List<Question> retryQuestions = questionRepository.findAllByMockApplyIdOrderByIdAsc(response.mockApplyId());
assertThat(response.sourceMockApplyId()).isEqualTo(sourceMockApply.getId());
assertThat(response.jobPostingId()).isEqualTo(jobPosting.getId());
assertThat(response.sequence()).isEqualTo(2);
assertThat(response.status()).isEqualTo(MockApplyStatus.ANSWER_WRITE);
assertThat(retryMockApply.getApplyType()).isEqualTo(ApplyType.MOCK);
assertThat(retryMockApply.getJobPosting().getId()).isEqualTo(jobPosting.getId());
assertThat(retryMockApply.getSequence()).isEqualTo(2);
assertThat(retryMockApply.getStatus()).isEqualTo(MockApplyStatus.ANSWER_WRITE);
assertThat(retryJobPosting.getId()).isNotEqualTo(jobPosting.getId());
assertThat(retryJobPosting.getId()).isEqualTo(jobPosting.getId());
assertThat(retryJobPosting.getCompany().getId()).isEqualTo(jobPosting.getCompany().getId());
assertThat(retryJobPosting.getDetailClassification().getId()).isEqualTo(jobPosting.getDetailClassification().getId());
assertThat(retryJobPosting.getTask()).isEqualTo(jobPosting.getTask());
Expand Down
Loading