Merged
Conversation
Collaborator
|
Sorry i missed this PR. will review when i have time. looks fine at first glance. |
Collaborator
|
Thank you for contributing @AzemaViator released as effect-playwright@0.2.4 |
Collaborator
|
@AzemaViator also thanks for the idea with the coverage script. i implemented as a CLI with effect cli. Not sure if it's better than what you have honestly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my use case, I need access to the persistent context launch option.
This was created using Codex, and I am newer to effect, so I am not 100% sure on the test cases, but the code for
launchPersistentContextfollows the same logic fromlaunch/connectCDP, so I feel that this PR should not be a waste of your time to review.I also created an API coverage tracker with Codex, but I wasn't sure if it would be wanted, so I am not opening a PR for it atm.