Merged
Conversation
fiws
force-pushed
the
refactor/unwrap-safe-methods
branch
4 times, most recently
from
3e43f29 to
ad7346f
Compare
fiws
force-pushed
the
refactor/unwrap-safe-methods
branch
from
ad7346f to
613e9fa
Compare
meowhib
suggested changes
Feb 16, 2026
meowhib
left a comment
meowhib
left a comment
There was a problem hiding this comment.
i think we need to update the readme file too
Unwrap `ok`, `status`, `statusText`, and `fromServiceWorker` in `PlaywrightResponse` from `Effect` to simple synchronous thunks. These properties are available on the underlying Playwright object without async calls or potential errors.
fiws
force-pushed
the
refactor/unwrap-safe-methods
branch
from
635d096 to
38661e1
Compare
StefanWerW
approved these changes
Feb 17, 2026
Contributor
StefanWerW
left a comment
StefanWerW
left a comment
There was a problem hiding this comment.
Looks good overall.
Again, like we have spoken, this is more a option thing, I would maybe prefer all function being effect instead of direct function for safe methods. But I also do not have strong arguments for my preference or/and against this, and is also not wrong at all.
So if you feel that is more ergonomic this way, we can proceed like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used AI to check each method if it can throw. Added a skill just for this.
This change makes certain things less cumbersome because you don't have to yield stuff. Logging the URL is a very common thing for example, which now can be fully synchronous.