Skip to content

Validate Codex 0.131 and 0.132 CLI compatibility#94

Merged
JoeyTeng merged 1 commit into
masterfrom
codex/codex-131-132-compatibility
May 20, 2026
Merged

Validate Codex 0.131 and 0.132 CLI compatibility#94
JoeyTeng merged 1 commit into
masterfrom
codex/codex-131-132-compatibility

Conversation

@JoeyTeng
Copy link
Copy Markdown
Owner

@JoeyTeng JoeyTeng commented May 20, 2026

Note

This PR is purely generated by LLM: OpenAI Codex (GPT-5.5 (reasoning xhigh, summaries auto)).

Summary

  • Extend the soft validated Codex CLI compatibility range from 0.130.x to 0.130.x-0.132.x.
  • Add codex doctor coverage for accepted 0.130/0.131/0.132 versions and keep future 0.133+ versions warning by default.
  • Update live fresh-foreground wrappers to allocate a pseudo-terminal for Codex 0.132 TUI startup guards on Darwin and Linux.
  • Harden the live PTY wrappers to track the real foreground Codex PID, fail fast on unexpected PTY startup exits, propagate non-zero wrapper exits, and suppress raw TUI transcript output.
  • Refresh design/status/TODO/project-journal notes for the compatibility update.

Validation

  • cargo test --locked
  • cargo test --locked doctor_cli -- --nocapture
  • CBTH_RUN_LIVE_CODEX_E2E=1 cargo test --test live_smoke -- --ignored --nocapture
  • CBTH_RUN_LIVE_TRUSTED_ALL_E2E=1 cargo test --test live_trusted_all -- --ignored --nocapture
  • CBTH_RUN_LIVE_NEW_THREAD_E2E=1 cargo test --test live_new_thread -- --ignored --nocapture
  • CBTH_RUN_LIVE_TASK_SUPERVISOR_E2E=1 cargo test --test live_task_supervisor -- --ignored --nocapture
  • cargo fmt --all -- --check
  • cargo clippy --locked --all-targets -- -D warnings
  • git diff --check
  • uv run python /Users/hoteng/.codex/personal-sync/releases/dcb64bf00f2f3d3b2c78edf69dc00c87c416ad9c/personal_codex/skills/project-journal/scripts/project_journal.py validate --repo /Users/hoteng/.codex/worktrees/37fd/codex-background-task-handler

Review Tracking

  • github-codex-review: clean on head 897204709d12f9377ec52a0ed67f2d2c3d912f36; codex/review-gate completed successfully with "Codex completion observed and current head has no Codex findings", and all Codex review threads are resolved.
  • independent-codex-pr-review: clean on PR Validate Codex 0.131 and 0.132 CLI compatibility #94 plus local checkout range d58400f259f94c7d0fb9a645592ff90379d5188b..897204709d12f9377ec52a0ed67f2d2c3d912f36; final artifact says LGTM; no actionable findings.
  • offline-frozen-diff-review: clean on frozen range d58400f259f94c7d0fb9a645592ff90379d5188b..897204709d12f9377ec52a0ed67f2d2c3d912f36; default codex-review was unavailable due readonly git shim rejection of git -c, and codex-readonly fallback final artifact says LGTM.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

codex/review-gate state

  • head: 897204709d12f9377ec52a0ed67f2d2c3d912f36
  • marker: none
  • updated: 2026-05-20T10:49:55.123Z

@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec70efb04f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/live_new_thread.rs Outdated
Comment thread tests/live_task_supervisor.rs Outdated
Comment thread tests/live_new_thread.rs Outdated
@JoeyTeng JoeyTeng force-pushed the codex/codex-131-132-compatibility branch from ec70efb to 3901978 Compare May 20, 2026 09:55
@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3901978e45

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/live_new_thread.rs Outdated
Comment thread tests/live_new_thread.rs
@JoeyTeng JoeyTeng force-pushed the codex/codex-131-132-compatibility branch from 3901978 to ea29650 Compare May 20, 2026 10:10
@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@JoeyTeng JoeyTeng force-pushed the codex/codex-131-132-compatibility branch from ea29650 to a84321d Compare May 20, 2026 10:28
@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Extend the soft validated Codex CLI range through 0.132.x, add doctor coverage for the accepted range, and keep future versions warning by default.

Update live fresh-foreground wrappers to allocate a PTY for Codex 0.132 TUI startup guards, feature-detect Linux script exit-status support, detect unexpected foreground exits, record the real foreground Codex PID for teardown, and suppress TUI output from test stdout pipes.

Co-authored-by: Codex (model=GPT-5) <codex@openai.com>
@JoeyTeng JoeyTeng force-pushed the codex/codex-131-132-compatibility branch from a84321d to 8972047 Compare May 20, 2026 10:39
@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@JoeyTeng JoeyTeng merged commit a3a2240 into master May 20, 2026
5 checks passed
@JoeyTeng JoeyTeng deleted the codex/codex-131-132-compatibility branch May 20, 2026 10:52
@JoeyTeng JoeyTeng restored the codex/codex-131-132-compatibility branch May 20, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant