Update to Minecraft 26.2#391
Merged
Merged
Conversation
Owner
|
Thanks for the upgrade! I'll review today. |
arnokeesman
reviewed
Jun 16, 2026
Contributor
|
tests also seem to run fine if I don't update gradle and loom, so guess there's some gradle hell ahead |
Owner
|
currently worried this is going to use the nevermind, I simply failed to read. Huzzah! public static Identifier of(String name) {
return Identifier.fromNamespaceAndPath("essentialcommands", name);
} |
Owner
|
Looks good to me. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the mod to Minecraft 26.2 (currently release candidate 2). With this update, the mod moves to use Fabric API's new permissions API, which uses Minecraft's identifiers as permission nodes.
Permission managers like LuckPerms "flatten" these identifiers into a string by replacing the
:with a.. For example,essentialcommands:tpaturns intoessentialcommands.tpa. As such, the user-facing permission strings when using LuckPerms should remain unchanged.Unsure on how to address the failing tests at the moment.