Adjust how fieldAsText method in Config handles optional values#75
Merged
John-Paul-R merged 1 commit intoJohn-Paul-R:masterfrom Oct 28, 2021
Merged
Conversation
Owner
|
Seems this slipped through the cracks when I introduced the I appreciate the link to the relevant stackoverflow as well 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to display the config currently you seen an exception related to the use of field.get() in this method. This change instead casts the field as an optional value and gets the string value of the optional.
Due to
Essential-Commands/ec-core/src/main/java/dev/jpcode/eccore/config/Config.java
Line 63 in 03c32d0