Skip to content

Conversation

@danilojsl
Copy link
Contributor

Description

Adding storeContent parameter to display raw content from files only if the user requires it.

Motivation and Context

Better latency performance

How Has This Been Tested?

Screenshots (if appropriate):

  • Local Tests
  • Google Colab notebooks

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl self-assigned this Mar 6, 2025
@danilojsl danilojsl requested a review from maziyarpanahi March 6, 2025 01:29
@danilojsl danilojsl added enhancement DON'T MERGE Do not merge this PR labels Mar 6, 2025
@danilojsl danilojsl force-pushed the feature/SPARKNLP-1117-Adding-storeContent-parameter-on-readers branch from 81ba584 to 9386b44 Compare March 6, 2025 14:50
@maziyarpanahi
Copy link
Contributor

@danilojsl I can't set this branch on release/600-release-candidate - it seems all the changes here are already in that brach. Can you check please?

@danilojsl
Copy link
Contributor Author

@maziyarpanahi You're absolutely right. The changes are already in one of the existing PRs, so this PR is no longer needed. Thanks for catching that!

@danilojsl danilojsl closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DON'T MERGE Do not merge this PR enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants