Skip to content

Conversation

@jsl-models
Copy link
Collaborator

No description provided.

@danilojsl danilojsl requested a review from maziyarpanahi June 29, 2022 16:10
@maziyarpanahi
Copy link
Contributor

@danilojsl this PR should be closed right?

@danilojsl
Copy link
Contributor

danilojsl commented Jul 4, 2022

Hi @maziyarpanahi, no for version 4.0.0, it requires retraining this pipeline model I think it is because of the new scala version used in 4.0.0.

@danilojsl danilojsl closed this Jul 4, 2022
@danilojsl danilojsl reopened this Jul 4, 2022
@maziyarpanahi
Copy link
Contributor

@danilojsl I think we are good now without this model? https://github.com/maziyarpanahi/spark-nlp-py-starter/actions/runs/2605675326

@danilojsl
Copy link
Contributor

danilojsl commented Jul 5, 2022

@maziyarpanahi it looks like that, but if the tested code has a pretrained() call it's because the pipeline model for 3.4.4 and 4.0.0 is already on S3

@maziyarpanahi
Copy link
Contributor

@danilojsl I forgot this is a pipeline. So could you please have a look at the conflict, it seems something with the same name was uploaded already and merged

@danilojsl
Copy link
Contributor

Sure, I resolved the conflict

@maziyarpanahi maziyarpanahi merged commit 7ca33cc into models_hub Jul 11, 2022
@maziyarpanahi maziyarpanahi deleted the 2022-06-29-dependency_parse_en_3_0_lofqq1ADO3FSEUN2VIcnlN4l branch September 13, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants