Source API version from package.json and validate infoURL protocol#32
Merged
Johnaverse merged 2 commits intofix/sonarqube-code-quality-v1.1.0from Mar 7, 2026
Merged
Conversation
Co-authored-by: Johnaverse <110527930+Johnaverse@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SonarQube issues and bump version to 1.1.0
Source API version from package.json and validate infoURL protocol
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GET /endpoint returned a hardcodedversion: '1.0.0'regardless ofpackage.json, andshowWebsite()in the frontend created anchor elements fromdata.infoURLwithout protocol validation, allowing non-http(s) schemes (e.g.,javascript:) to be rendered as clickable links.Changes
index.js— Replace hardcoded'1.0.0'withpkg.versionvia JSON import assertion:public/app.js— ValidateURL.protocolinshowWebsite()before creating an anchor; any non-http:/https:scheme or invalid URL falls back to plain text:tests/integration/api.test.js— Update version assertion from'1.0.0'to'1.1.0'to matchpackage.json.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.