Fix broken merge state: restore app.js functions, pkg import, and refactor collectRelationEdges#34
Merged
Johnaverse merged 2 commits intofix/sonarqube-code-quality-v1.1.0from Mar 7, 2026
Conversation
…collectRelationEdges Co-authored-by: Johnaverse <110527930+Johnaverse@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SonarQube issues and bump version to 1.1.0
Fix broken merge state: restore app.js functions, pkg import, and refactor collectRelationEdges
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bad merge left several critical runtime breakages across
index.js,public/app.js, anddataService.js— causingGET /to 500, the graph UI to fail loading data, and the details panel to render incomplete.index.js
import pkg from './package.json' with { type: 'json' }—pkg.versionwas referenced but never imported, causing everyGET /request to throw aReferenceErrorpublic/app.js
fetchExportData: Fixed duplicatelet resdeclaration, improperly nestedtry, and missingres.json()return (was returning undefinedrelations)buildRelationsMap: Restored function that was lost in the merge but still called byfetchDatashowNodeDetails: Restored full function body — was truncated after the status badge, omitting currency, parent/child chains, RPCs, explorers, website rendering, and panel revealshowWebsite: Replaced broken implementation (unclosedtry, out-of-scopenode/panelvariables) with correct URL protocol validation — onlyhttp:/https:schemes render as links; others fall back to plain text:dataService.js
collectRelationEdges: Added missing edge deduplication logic; updatedtraverseRelationsto delegate to this helper using aSetfor O(1) key lookup instead of the previous O(n²)Array.some()scan per edge💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.