Source Control Provider tab duplicates an external when saving files.

[Arwalk]

• VSCode Version: 1.20.1
• OS Version: Ubuntu 14.04
• Extension Version: 1.20
• System Language: English
• SVN Version: 1.8.8

Issue

The repository i work with heavily uses externals. Since the latest VSCode update, every time i save a file, the first recognized external is duplicated in the Source Control Provider tab.
Example. If i do a fresh checkout, my Source Control Providers will look like this:

---

main repo
external 1
external 2
external 3
external 4

As soon as i modify and save a file, it looks like this:

---

main repo
external 1
external 2
external 3
external 4
external 1

If i make another modification..

---

main repo
external 1
external 2
external 3
external 4
external 1
external 1

This behaviour happens if i make multiple modifications on a single file and when i modify multiple files. Every time i save my file, the external gets duplicated in the view.

The IDE starts to slow down more and more with every additional duplicate.

On a window reload or restart of VSCode, everything goes back to normal (until the next file is saved).

It seems that only one of the external is consistently duplicated, even if the file that was saved and modified is not in the duplicated external.

To avoid this, i use the new svn.detectExternals setting to false,but it sadly doesn't recognize modifications in the externals when i'm using it.

Steps to Reproduce

1. Have a svn repository relying on multiple externals
2. Modify and save any file in this repo

[edgardmessias]

@Arwalk, Does the problem occur if you run refresh?

[Arwalk]

It actually creates a new duplicate every time i click on the "refresh" button of the "main repo".

Refreshing any other external, even on the one that is duplicated (original or duplicated), doesn't do anything.

[edgardmessias]

@Arwalk , test with https://ci.appveyor.com/api/buildjobs/454fvfbp3kqyelg4/artifacts/svn-scm.vsix

Tutorial: https://code.visualstudio.com/docs/editor/extension-gallery#_install-from-a-vsix

[Arwalk]

No source control providers seems to be recognized at all with this version. I even safely uninstalled the previous version before trying with the vsix you just sent.

[JohnstonCode]

@edgardmessias do we know whats causing this?

[edgardmessias]

@JohnstonCode, I'm investigating, maybe it's the getRepository

@Arwalk, you can send your folder structure?
Send result of svn status in root of main repository

[Arwalk]

here it is, obviously removed names to avoid any possible problem with my workplace :)

?       .vscode
X       [EXTERNAL 1]
X       cmake

Performing status on external item at 'cmake':

Performing status on external item at '[EXTERNAL 1]':
?       [EXTERNAL 1]/Data/[EXTERNAL 4]
X       [EXTERNAL 1]/path/to/this/place/[EXTERNAL 2]
X       [EXTERNAL 1]/path/to/this/place/[EXTERNAL 3]

Performing status on external item at '[EXTERNAL 1]/path/to/this/place/[EXTERNAL 2]':

Performing status on external item at '[EXTERNAL 1]/path/to/this/place/[EXTERNAL 3]':

Performing status on external item at '[EXTERNAL 1]/Data/[EXTERNAL 4]':

It might come from [EXTERNAL 1] itself being full of externals.

[JohnstonCode]

Thanks for that @Arwalk

Going to set up a test environment that has the same level of external nesting and see if I can reproduce.

[JohnstonCode]

Yeah seem all the nesting breaks something.

[JohnstonCode]

@edgardmessias here is the problem

[edgardmessias]

@JohnstonCode, you can send me you repository of test?

[JohnstonCode]

would be a pain as its all mapped to file:///.

Issue is the order of arguments for isDescendant

[JohnstonCode]

This Does however rasied the issue of us testing stuff for all types of sanarios. Do you think there would be a benfit of me setting up an SVN repo on my server we can both access? @edgardmessias