Skip to content

Conversation

@edgardmessias
Copy link
Contributor

Added green letter "H" for HEAD and blue letter "B" for base.
Hide the icons on non SVN repositories;

@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #137 into master will decrease coverage by 0.24%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   41.22%   40.97%   -0.25%     
==========================================
  Files          17       17              
  Lines        1441     1457      +16     
  Branches      227      227              
==========================================
+ Hits          594      597       +3     
- Misses        845      858      +13     
  Partials        2        2
Impacted Files Coverage Δ
src/extension.ts 0% <0%> (ø) ⬆️
src/model.ts 59.74% <61.53%> (-0.4%) ⬇️
src/svnRepository.ts 65.43% <0%> (-1.24%) ⬇️
src/svn.ts 61.84% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a72859b...859defe. Read the comment docs.

@JohnstonCode JohnstonCode merged commit c275349 into JohnstonCode:master Feb 2, 2018
@johnjacobkenny
Copy link
Contributor

The new icons do help, but the letters aren't that legible, is there some way to make the letters appear bigger?
image

@edgardmessias
Copy link
Contributor Author

You can edit SVGs

@JohnstonCode
Copy link
Owner

@johnjacobkenny Edit the SVSs and see if you can create something clearer

@johnjacobkenny
Copy link
Contributor

Is there any precedence I should keep in mind for the design of the button?
Also, I haven't worked with SVGs before, do you use any software to edit them? Something like Inkscape?

@JohnstonCode
Copy link
Owner

Not sure I try not to deal with graphics.

I'm sure a quick google should throw something up.

As long as the design gits in the VS code I'm not fussy.

@edgardmessias
Copy link
Contributor Author

SVN is like HTML, you can start here: https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial

Or use Inkscape

@edgardmessias edgardmessias deleted the fix_diff_icons branch February 19, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants