-
-
Notifications
You must be signed in to change notification settings - Fork 94
feat:Incoming changes shown in TreeView #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
- Coverage 60.65% 58.96% -1.69%
==========================================
Files 38 44 +6
Lines 2613 2737 +124
Branches 478 487 +9
==========================================
+ Hits 1585 1614 +29
- Misses 1021 1116 +95
Partials 7 7
Continue to review full report at Codecov.
|
|
@edgardmessias can you have a look through. Got it working and hocked up to the status change event. Should i remove the remotechanged resource group? |
|
I also need to do #312 |
|
Should also use regex for commands example |
|
I will take a look |
|
@JohnstonCode, for treeview, add support to folders of files |
|
@edgardmessias i did run into issues with folders. How do we know what is a file and what is a folder if it is added. I didn't want to make more requests to query each type. Do you have any ideas? |
|
In Check the Group changes by folder and update the folderPath with new part |
|
For folder, create a new node type |
|
@edgardmessias i see what you mean so have the elements nested in their folder? But my questiong is if the incoming change is a folder how do you tell its a folder. For example
How do you work out whats a folder as you cant use fs.lstatSync as the changes only exist on remote. |
|
Another single solution: get label() {
return path.relative(this.repository.workspaceRoot, this.uri.fsPath);
} |
|
SVN return only file in |
|
Example: Generate:
|
|
I get you now. I’ll get that sorted tomorrow |
|
Ok, first, merge the master branch and resolve the conflicts |
|
@edgardmessias Changes have been made. Went with updating the label. |
|
@edgardmessias ping! |
|
To-Do:
|
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is currently a WIP