Skip to content

Conversation

@edgardmessias
Copy link
Contributor

My idea to improve model.ts:

  • Create more events (When necessary)
  • Move code to another files and use events

@JohnstonCode
Copy link
Owner

How do we use contexts?

@edgardmessias
Copy link
Contributor Author

Used to show/hide "Open changes BASE/HEAD" in editor

Here:

"when": "config.svn.enabled && svnOpenRepositoryCount != 0 && svnActiveEditorHasChanges"

"when": "config.svn.enabled && svnOpenRepositoryCount != 0 && svnActiveEditorHasChanges && !isInDiffEditor && resourceScheme == file"

@JohnstonCode
Copy link
Owner

Aaah right. Was looking through VS docs and found nothnig that referenced them thats all

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #517 into master will increase coverage by 0.11%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   56.13%   56.25%   +0.11%     
==========================================
  Files          97       98       +1     
  Lines        3928     3943      +15     
  Branches      571      571              
==========================================
+ Hits         2205     2218      +13     
- Misses       1512     1514       +2     
  Partials      211      211
Impacted Files Coverage Δ
src/model.ts 60.51% <100%> (-1.59%) ⬇️
src/extension.ts 70.96% <100%> (+0.63%) ⬆️
src/contexts/checkActiveEditor.ts 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6aeb92...c035d03. Read the comment docs.

@JohnstonCode JohnstonCode merged commit 0372744 into JohnstonCode:master Mar 20, 2019
@edgardmessias edgardmessias deleted the check_active_editor branch March 21, 2019 11:21
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 1.47.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants