Skip to content

Conversation

@edgardmessias
Copy link
Contributor

No description provided.

@JohnstonCode
Copy link
Owner

Do we not want to be caching node_modules?

@edgardmessias
Copy link
Contributor Author

Because there are no difference in my tests, probably there are a github proxy/cache for npm modules.

@JohnstonCode
Copy link
Owner

Yeah must be only took 13 seconds.

Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JohnstonCode JohnstonCode changed the title Improved workflow chore: Improved workflow Feb 12, 2020
@JohnstonCode JohnstonCode merged commit 3f7482f into JohnstonCode:master Feb 12, 2020
@edgardmessias
Copy link
Contributor Author

Small note: I use ${{ github.run_id }} in cache key for vscode, because each day, the insiders version change and the github cache is immutable.
Some times stable version change too.
Is most cheap to store cache every run

@JohnstonCode
Copy link
Owner

Yeah i saw that.

@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 2.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants