Merged
Conversation
ceolson01
approved these changes
Jan 22, 2020
Contributor
ceolson01
left a comment
There was a problem hiding this comment.
This looks good to me - nice improvements. Also, thanks for commenting so thoroughly for our future selves 👍
55d0d78 to
098829b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR started it's life as a way to do cache-busting in new deployments by inserting a content hash in the name of the outputted bundle.
In the end it turned into:
The next step in this saga, is to add in code splitting, ... at some point.
New stuff
clean-webpack-pluginpackagebaseconfig, from which all else inheritprodconfig, for production env buildsdevconfig, for development env builds and out of which theyarn devserver runsDeletions
webpack.config.jsdevelopment configwebpack.config.prod.jsproduction configScreenshots