Merged
Conversation
ceolson01
approved these changes
Jan 31, 2020
Contributor
ceolson01
left a comment
There was a problem hiding this comment.
Aha! Good find, good fix 💪
chmanie
approved these changes
Feb 2, 2020
Member
chmanie
left a comment
There was a problem hiding this comment.
Urgh, what a major oversight. Thanks for fixing this!
c7e5de2 to
7493481
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in a simple fix in order to display to correct ETH amount in the user wallet's cards list.
What is happening in the background is that for ETH, we're using the provider to make a
getBalancecall to the network and fetch that address's current balance.For other tokens, we just use the our contracts' internal book-keeping to get the balance.
Now, that get balance call is async, as it should be, but we we're waiting for it resolve, and just returned the unresolved promise, as a string:
Our
<Numeral />component either did some clever converting, or fell back to a default value to produce that0.00385....value you see in the before screenshot.The fix for this, was just to wait for that promise to finish, which returns a BigNumber, and that, converted to a string, gets us the actual value in wei:
Changes
tokengql resolver, wait forgetBalancecall to resolveScreenshots
Before:

After:

Resolves #2011