Conversation
2c6d625 to
1bb2819
Compare
src/data/queries.graphql
Outdated
| } | ||
| } | ||
|
|
||
| query UserWithReputation($address: String!, $colonyAddress: String!, $skillId: Int) { |
There was a problem hiding this comment.
I initially planned to use this query, but later decided to use the UserReputation query instead, as it was a bit more efficient to handle the data fetching as needed, rather each time a user is fetched. I've left this here, though, as I feel like it might prove useful in the future. Not opposed to removing it, though
There was a problem hiding this comment.
Cool! Can you add this as a comment in the code for the future-us?
| * subscribe to colony call to action | ||
| */ | ||
| hasJoined: username ? hasJoined : true, | ||
| hasJoined: username ? !!hasJoined : true, |
There was a problem hiding this comment.
This fixes the weird ICU syntax error that would happen sometimes in the colony home (if there are no tasks and the user is not subscribed to the colony)
chmanie
left a comment
There was a problem hiding this comment.
Some quirks, all in all fantastic work! I'm happy
src/data/queries.graphql
Outdated
| } | ||
| } | ||
|
|
||
| query UserWithReputation($address: String!, $colonyAddress: String!, $skillId: Int) { |
There was a problem hiding this comment.
Cool! Can you add this as a comment in the code for the future-us?
9652345 to
faff9ee
Compare
Improve appearance typings
Update `UserBadges` query to only query within a colony
* Popovers did not play well with `Table` * Eventually should use this in place of `UserList` in colony admin
`div` cannot appear as a descendant of `<p>`
9775e00 to
6f68e37
Compare
6f68e37 to
9594b33
Compare
chmanie
left a comment
There was a problem hiding this comment.
What a rename! All seems well
Description
This PR adds a user's reputation to the member popover.
New stuff ✨
UserReputationqueryUserWithReputationquery (may remove - let's discuss)Changes 🏗
MemberPopoverfor use within a colonyNumeralappearance flexibility & typingsUserBadgesquery to only display badges within the current colonyTODO
colonyAddressandskillId) toAssignmentinstanceCommunitytabScreenshots 📷
Closes #2026