Merged
Conversation
It can now support a second argument that servers as a manual fallback in addition to the value we already fall back to
chmanie
approved these changes
Apr 23, 2020
Member
chmanie
left a comment
chmanie
left a comment
There was a problem hiding this comment.
Hooray! Great fix. This looks good to me
| * a number, and return that number (even if that number is 0). | ||
| * If it's not a number then fallback to the default token decimals value. | ||
| */ | ||
| export const getTokenDecimalsWithFallback = ( |
Member
There was a problem hiding this comment.
I find the name a bit long (especially because we don't have a getTokenDecimals function. But better too long than too short, I guess!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the tokens values displays within the app, for tokens which report they're
decimalsvalue as0(zero).This was previously causing the
0value to be treated asfalse, which would have had triggered the18decimals value fallback.Reviewer Note: This needs to be tested with it's server counterpart: JoinColony/colonyServer#95
New stuff
getTokenDecimalsWithFallbacktoken utilChanges
tokenclient side query now usesgetTokenDecimalsWithFallbackfor tokens decimals displayTokenItemnow usesgetTokenDecimalsWithFallbackfor tokens decimals displayTokenCardnow usesgetTokenDecimalsWithFallbackfor tokens decimals displayTokenMintDialognow usesgetTokenDecimalsWithFallbackfor tokens decimals displayTokenMintDialogFormnow usesgetTokenDecimalsWithFallbackfor tokens decimals displayTokenIMoveDialognow usesgetTokenDecimalsWithFallbackfor tokens decimals displayTokenIMoveDialogFormnow usesgetTokenDecimalsWithFallbackfor tokens decimals displayAmountTokensnow usesgetTokenDecimalsWithFallbackfor tokens decimals displayPayoutsListnow usesgetTokenDecimalsWithFallbackfor tokens decimals displayTransactionListItemnow usesgetTokenDecimalsWithFallbackfor tokens decimals displayColonyInitialFundingnow usesgetTokenDecimalsWithFallbackfor tokens decimals displayTaskFeedCompletedInfonow usesgetTokenDecimalsWithFallbackfor tokens decimals displayTaskFeedEventnow usesgetTokenDecimalsWithFallbackfor tokens decimals displayScreenshots
Before
After
Resolves #2133