113 remove own user from user searching functions#118
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements new functionality to add pagination-based user searching by name and corresponding exception handling, as part of the effort to remove the own user from search results.
- Added getPaginationByName methods to the repository, service, and controller layers.
- Introduced new tests for successful pagination and exception cases in multiple modules.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| API/src/test/java/es/iespuertodelacruz/routinefights/user/infrastructure/adapters/secondary/services/UserEntityServiceTest.java | Added tests for getPaginationByName functionality. |
| API/src/test/java/es/iespuertodelacruz/routinefights/user/infrastructure/adapters/primary/v2/controllers/UserControllerV2Test.java | Added controller tests for paginated user search. |
| API/src/test/java/es/iespuertodelacruz/routinefights/user/domain/services/UserServiceTest.java | Updated domain service tests for new pagination support. |
| API/src/main/java/es/iespuertodelacruz/routinefights/user/infrastructure/adapters/secondary/services/UserEntityService.java | Added getPaginationByName implementation with try-catch handling. |
| API/src/main/java/es/iespuertodelacruz/routinefights/user/infrastructure/adapters/secondary/repositories/IUserEntityRepository.java | Added query for paginated user search. |
| API/src/main/java/es/iespuertodelacruz/routinefights/user/infrastructure/adapters/primary/v2/controllers/UserControllerV2.java | Added new controller endpoint for paginated user search. |
| API/src/main/java/es/iespuertodelacruz/routinefights/user/domain/services/UserService.java | Added getPaginationByName method calculating offset from page. |
| API/src/main/java/es/iespuertodelacruz/routinefights/user/common/IUserCommon.java | Extended common interface with getPaginationByName. |
Files not reviewed (1)
- API/src/main/resources/graphql/schema.graphqls: Language not supported
Comments suppressed due to low confidence (1)
API/src/test/java/es/iespuertodelacruz/routinefights/user/infrastructure/adapters/primary/v2/controllers/UserControllerV2Test.java:314
- Given the PR title indicates removal of the own user from search results, it would be valuable to add tests that verify the own user is not included in the paginated results.
void getPaginationByNameTest() {
Collaborator
|
You have to remove the own user from the search function |
JonayKB
added a commit
that referenced
this pull request
Jan 24, 2026
…arching-functions 113 remove own user from user searching functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.