feat(HtmlTemplates): Improved styles#145
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the HTML templates used for various email notifications by consolidating common styles into a constant and updating each template to include consistent styling and layout updates.
- Introduces a COMMON_STYLES constant for shared style definitions.
- Updates multiple HTML templates (VERIFICATION_EMAIL, NEED_EMAIL_TOKEN, ERROR, VERIFIED, BAD_REQUEST) to use the new styles and a consistent container structure.
| </body> | ||
| </html> | ||
| """; | ||
| """.formatted(COMMON_STYLES, "%s", "%s"); |
There was a problem hiding this comment.
[nitpick] The use of hardcoded "%s" placeholders in the formatted call for VERIFICATION_EMAIL may be unclear to future maintainers; consider adding inline comments or using descriptive constants to clarify their purpose.
| """.formatted(COMMON_STYLES, "%s", "%s"); | |
| """.formatted(COMMON_STYLES, EMAIL_PLACEHOLDER, TOKEN_PLACEHOLDER); |
| </html> | ||
| """; | ||
| """.formatted(COMMON_STYLES, "%s", "%s"); | ||
|
|
There was a problem hiding this comment.
[nitpick] Document the expected content for the "%s" placeholder in the NEED_EMAIL_TOKEN template head to ensure consistency and clarity for future modifications.
| // The %s placeholder in the <head> section is intended for including common styles, | |
| // such as those defined in the COMMON_STYLES constant. |
| </html> | ||
| """; | ||
| """.formatted(COMMON_STYLES, "%s"); | ||
|
|
There was a problem hiding this comment.
[nitpick] Similarly, include documentation or a brief comment for the "%s" placeholder in the VERIFIED template to clarify what content is expected in that position.
| // The %s placeholder in the VERIFIED template is replaced with additional styles or metadata for the <head> section. |
…-verification feat(HtmlTemplates): Improved styles
No description provided.