140 change api html templates of verification#146
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API HTML templates for verification by adding a null check to the comments mapping function to improve stability.
- Adds a null check in the mapCommentsToComments method
- Returns an empty list when the input commentsEntities is null
Comments suppressed due to low confidence (1)
API/src/main/java/es/iespuertodelacruz/routinefights/post/infrastructure/adapters/secondary/mappers/PostEntityMapper.java:27
- [nitpick] Consider whether returning an immutable empty list using List.of() is the intended behavior; if downstream consumers expect a modifiable list, using new ArrayList<>() might be more appropriate.
if (commentsEntities == null) {
JonayKB
added a commit
that referenced
this pull request
Jan 24, 2026
…-verification 140 change api html templates of verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.