Skip to content

129 create comunnity events base#147

Merged
JonayKB merged 18 commits into
mainfrom
129-create-comunnity-events-base
May 16, 2025
Merged

129 create comunnity events base#147
JonayKB merged 18 commits into
mainfrom
129-create-comunnity-events-base

Conversation

@JonayKB
Copy link
Copy Markdown
Owner

@JonayKB JonayKB commented May 16, 2025

No description provided.

@JonayKB JonayKB requested review from Copilot and rabgonzalez May 16, 2025 11:53
@JonayKB JonayKB self-assigned this May 16, 2025
@JonayKB JonayKB linked an issue May 16, 2025 that may be closed by this pull request
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces community event support and refactors the badge functionalities. Key changes include:

  • Adding new repository query methods to fetch badges related to community events.
  • Refactoring the BadgeEntity to extend shared properties from BadgeCommons, including changing level from String to Integer and updating related getter/setter naming.
  • Enhancing mapping, service, and controller layers for both v2 and v3 APIs while adding new Activity image queries.

Reviewed Changes

Copilot reviewed 47284 out of 47284 changed files in this pull request and generated no comments.

Show a summary per file
File Description
IBadgeEntityRepository.java Added queries for fetching badges by community events and users.
BadgeEntity.java Refactored to extend BadgeCommons, updated property types, and renamed getters/setters.
Mapper and DTO files Updated to reflect changes in BadgeEntity and API versions.
BadgeService.java and related ports Adjusted method signatures and parameters to support new community event logic.
Activity repository and service files Introduced new method to retrieve all activity images.
pom.xml Updated dependency versions and added new testing plugins.
Comments suppressed due to low confidence (3)

API/src/main/java/es/iespuertodelacruz/routinefights/badge/infrastructure/adapters/secondary/entities/BadgeEntity.java:110

  • [nitpick] The toString method still labels the users field as 'user', which may be misleading. Consider updating the label to 'users' for consistency.
", user='" + getUsers() + "'" +

API/src/main/java/es/iespuertodelacruz/routinefights/badge/infrastructure/adapters/secondary/entities/BadgeEntity.java:70

  • [nitpick] The parameter name 'user' in the 'users' method is ambiguous given that it represents a list of users. Consider renaming it to 'users' for clarity.
public BadgeEntity users(List<UserEntity> user) {

API/src/main/java/es/iespuertodelacruz/routinefights/badge/domain/services/BadgeService.java:48

  • [nitpick] The parameter name 'name' is ambiguous in the context of an email lookup. It is recommended to rename it to 'email' for clarity.
public List<Badge> findByUserEmail(String name) {

@JonayKB JonayKB merged commit 3680132 into main May 16, 2025
1 check passed
JonayKB added a commit that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Comunnity Events Base

2 participants