129 create comunnity events base#147
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces community event support and refactors the badge functionalities. Key changes include:
- Adding new repository query methods to fetch badges related to community events.
- Refactoring the BadgeEntity to extend shared properties from BadgeCommons, including changing level from String to Integer and updating related getter/setter naming.
- Enhancing mapping, service, and controller layers for both v2 and v3 APIs while adding new Activity image queries.
Reviewed Changes
Copilot reviewed 47284 out of 47284 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| IBadgeEntityRepository.java | Added queries for fetching badges by community events and users. |
| BadgeEntity.java | Refactored to extend BadgeCommons, updated property types, and renamed getters/setters. |
| Mapper and DTO files | Updated to reflect changes in BadgeEntity and API versions. |
| BadgeService.java and related ports | Adjusted method signatures and parameters to support new community event logic. |
| Activity repository and service files | Introduced new method to retrieve all activity images. |
| pom.xml | Updated dependency versions and added new testing plugins. |
Comments suppressed due to low confidence (3)
API/src/main/java/es/iespuertodelacruz/routinefights/badge/infrastructure/adapters/secondary/entities/BadgeEntity.java:110
- [nitpick] The toString method still labels the users field as 'user', which may be misleading. Consider updating the label to 'users' for consistency.
", user='" + getUsers() + "'" +
API/src/main/java/es/iespuertodelacruz/routinefights/badge/infrastructure/adapters/secondary/entities/BadgeEntity.java:70
- [nitpick] The parameter name 'user' in the 'users' method is ambiguous given that it represents a list of users. Consider renaming it to 'users' for clarity.
public BadgeEntity users(List<UserEntity> user) {
API/src/main/java/es/iespuertodelacruz/routinefights/badge/domain/services/BadgeService.java:48
- [nitpick] The parameter name 'name' is ambiguous in the context of an email lookup. It is recommended to rename it to 'email' for clarity.
public List<Badge> findByUserEmail(String name) {
JonayKB
added a commit
that referenced
this pull request
Jan 24, 2026
129 create comunnity events base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.