Skip to content

167 fix pagination and add event enhancements#173

Merged
rabgonzalez merged 2 commits into
mainfrom
167-add-loading-spinner-overlay
May 20, 2025
Merged

167 fix pagination and add event enhancements#173
rabgonzalez merged 2 commits into
mainfrom
167-add-loading-spinner-overlay

Conversation

@rabgonzalez
Copy link
Copy Markdown
Collaborator

No description provided.

@rabgonzalez rabgonzalez added this to the May milestone May 20, 2025
@rabgonzalez rabgonzalez requested a review from Copilot May 20, 2025 09:00
@rabgonzalez rabgonzalez self-assigned this May 20, 2025
@rabgonzalez rabgonzalez added the enhancement New feature or request label May 20, 2025
@rabgonzalez rabgonzalez linked an issue May 20, 2025 that may be closed by this pull request
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses pagination issues while enhancing event-related UI translations. Key changes include updating translation files with additional event messaging, simplifying post concatenation logic in several screens, and refining pagination conditions in activities loading.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
App/translations/{fr,es,en,de}.json Added new keys for event progress and final messages in multiple locales.
App/src/utils/Utils.tsx Updated convertQuantityToString to use optional chaining for the fallback.
App/src/screens/ProfileScreen.tsx Simplified the logic for appending new posts by removing deduplication.
App/src/screens/HomeScreen.tsx Refined concatenation of posts and adjusted createdAt slicing for pagination.
App/src/screens/EventsScreen.tsx Added UI elements to display event progress and final message.
App/src/screens/ActivitiesScreen.tsx Modified the pagination condition in loadMore function.
App/src/repositories/PostRepository.tsx Updated API field names and enhanced error logging.
Comments suppressed due to low confidence (1)

App/src/screens/ActivitiesScreen.tsx:64

  • The previous pagination condition checked if the loaded activity count was less than the expected total (pageNum.current * limit), which might have been used to prevent loading incomplete pages. Verify that changing the condition to activities.length === 0 appropriately handles the pagination logic.
if (isLoadingMore || activities.length === 0) return;

Comment thread App/src/utils/Utils.tsx
return parseFloat(num.toFixed(2)).toString() + "K";
}
return quantity.toString();
return quantity?.toString();
Copy link

Copilot AI May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the quantity parameter is statically typed as a number, the use of optional chaining may be unnecessary. Consider using quantity.toString() directly unless there is an explicit case where quantity can be undefined.

Suggested change
return quantity?.toString();
return quantity.toString();

Copilot uses AI. Check for mistakes.
@rabgonzalez rabgonzalez merged commit f04f7e3 into main May 20, 2025
1 check passed
JonayKB pushed a commit that referenced this pull request Jan 24, 2026
167 fix pagination and add event enhancements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add loading spinner overlay

2 participants