167 fix pagination and add event enhancements#173
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses pagination issues while enhancing event-related UI translations. Key changes include updating translation files with additional event messaging, simplifying post concatenation logic in several screens, and refining pagination conditions in activities loading.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| App/translations/{fr,es,en,de}.json | Added new keys for event progress and final messages in multiple locales. |
| App/src/utils/Utils.tsx | Updated convertQuantityToString to use optional chaining for the fallback. |
| App/src/screens/ProfileScreen.tsx | Simplified the logic for appending new posts by removing deduplication. |
| App/src/screens/HomeScreen.tsx | Refined concatenation of posts and adjusted createdAt slicing for pagination. |
| App/src/screens/EventsScreen.tsx | Added UI elements to display event progress and final message. |
| App/src/screens/ActivitiesScreen.tsx | Modified the pagination condition in loadMore function. |
| App/src/repositories/PostRepository.tsx | Updated API field names and enhanced error logging. |
Comments suppressed due to low confidence (1)
App/src/screens/ActivitiesScreen.tsx:64
- The previous pagination condition checked if the loaded activity count was less than the expected total (pageNum.current * limit), which might have been used to prevent loading incomplete pages. Verify that changing the condition to activities.length === 0 appropriately handles the pagination logic.
if (isLoadingMore || activities.length === 0) return;
| return parseFloat(num.toFixed(2)).toString() + "K"; | ||
| } | ||
| return quantity.toString(); | ||
| return quantity?.toString(); |
There was a problem hiding this comment.
Since the quantity parameter is statically typed as a number, the use of optional chaining may be unnecessary. Consider using quantity.toString() directly unless there is an explicit case where quantity can be undefined.
Suggested change
| return quantity?.toString(); | |
| return quantity.toString(); |
JonayKB
pushed a commit
that referenced
this pull request
Jan 24, 2026
167 fix pagination and add event enhancements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.