Patch workflow#191
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the CI/CD workflow to add timestamped Docker image tags alongside the latest tags, enabling version tracking of built images.
Key changes:
- Adds timestamp generation step to create unique version tags for Docker images
- Updates both Java API and administration image tagging to include timestamp-based tags
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Create TIMESTAMP | ||
| run: TIMESTAMP=$(date +%s) | ||
| ## CHECK THISSSS |
There was a problem hiding this comment.
Remove this TODO comment before merging. Comments like 'CHECK THISSSS' should be resolved and removed from production workflow files.
| ## CHECK THISSSS |
| run: | | ||
| ls | ||
| ls administration | ||
| tags: ${{ vars.DOCKERHUB_USERNAME }}/apiroutinefights:latest , ${{ vars.DOCKERHUB_USERNAME }}/apiroutinefights:$TIMESTAMP |
There was a problem hiding this comment.
The TIMESTAMP variable reference should use GitHub Actions syntax ${{ env.TIMESTAMP }} instead of shell variable syntax $TIMESTAMP. Additionally, remove the space after the comma in the tags list as it may cause parsing issues.
| file: administration/Dockerfile | ||
| push: true | ||
| tags: ${{ vars.DOCKERHUB_USERNAME }}/administrationroutinefights:latest | ||
| tags: ${{ vars.DOCKERHUB_USERNAME }}/administrationroutinefights:latest , ${{ vars.DOCKERHUB_USERNAME }}/administrationroutinefights:$TIMESTAMP |
There was a problem hiding this comment.
The TIMESTAMP variable reference should use GitHub Actions syntax ${{ env.TIMESTAMP }} instead of shell variable syntax $TIMESTAMP. Additionally, remove the space after the comma in the tags list as it may cause parsing issues.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.