fix(examples): de-bait example variants + layout/composition headers#43
Merged
fix(examples): de-bait example variants + layout/composition headers#43
Conversation
Agents scanning variants/ read the siblings as 'available templates to
reuse'. Moving the reference variants under variants/_reference/ (and
adding REFERENCE IMPLEMENTATION headers to every shipped layout module
and motion composition) makes the don't-copy-wholesale signal loud.
- Move variants/{example,ops-console-example,quote-card-example,stat-card-example}.json
→ variants/_reference/. walkthrough-ci-smoke.json stays in variants/
because it's CI infrastructure, not a creative reference.
- Add variants/_reference/README.md explaining what's reference vs what's
user content and pointing at composer-speccer + layout-synth / motion-synth.
- Add REFERENCE IMPLEMENTATION docstrings to advertorial, quote_card,
stat_card, OpsConsole, ProductMockup, Walkthrough, PhoneNotifications.
Each calls out that a new brand should invoke the synth skill rather
than reuse the file.
- Update README.md, setup SKILL.md, composer-speccer SKILL.md, render.sh
header comment, and test/run-tests.sh to the new paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agents scanning
variants/read the sibling*-example.jsonfiles as "available templates to reuse" — even when we tell them in skills not to. The fastest path kept winning: swap copy inops-console-example.json, rename, done. That's exactly how the recent Orbit E2E motion ended up looking like the HaniCare dispatcher UI.This PR rearranges the surface so the signal is physical, not just documentary.
Changes
variants/_reference/:variants/example.json→variants/_reference/example.jsonvariants/ops-console-example.json→variants/_reference/ops-console-example.jsonvariants/quote-card-example.json→variants/_reference/quote-card-example.jsonvariants/stat-card-example.json→variants/_reference/stat-card-example.jsonvariants/walkthrough-ci-smoke.jsonstays put — it's CI infra, not a creative reference.variants/_reference/README.mdexplaining what the folder is, why the underscore + subfolder, and pointing at the skill chain (composer-speccer→layout-synth/motion-synth).REFERENCE IMPLEMENTATIONdocstring headers to every shipped layout module and motion composition:engines/static/examples/advertorial.py,quote_card.py,stat_card.pyengines/motion/src/examples/OpsConsole.tsx,ProductMockup.tsx,Walkthrough.tsx,PhoneNotifications.tsxREADME.md,setup/SKILL.md,composer-speccer/SKILL.md,render.shheader comment,test/run-tests.sh.Why
Two incidents surfaced the problem:
layout-synth.composition: "ops-console"because the example variant was right there at top level — lowest-friction path.PRs #41 + #42 close the skill-chain and engine-error gaps. This one closes the visual/physical surface gap.
Test plan
npx adforge init <fresh-dir>→variants/_reference/+walkthrough-ci-smoke.jsonship correctly.templates/variants/_reference/README.mdrenders well on GitHub.test/run-tests.shstill passes locally against the new paths (verified by lint; full run blocks on CI).Part 3 of 3 in v0.3.3 (follows #41, #42). After merge: bump version + CHANGELOG + tag.