Skip to content

[auto-change] BUG-036: Echoes public-source intake smoke run fails on empty LLM response#463

Closed
Jonnyton wants to merge 1 commit intomainfrom
auto-change/issue-81-codex-25417406236
Closed

[auto-change] BUG-036: Echoes public-source intake smoke run fails on empty LLM response#463
Jonnyton wants to merge 1 commit intomainfrom
auto-change/issue-81-codex-25417406236

Conversation

@Jonnyton
Copy link
Copy Markdown
Owner

@Jonnyton Jonnyton commented May 6, 2026

Fixes #81

Writer family: Codex
Required checker family: Claude

Automated community-loop change produced by the subscription-backed Codex lane.

… empty LLM response

Fixes #81

Writer family: Codex

Required checker family: Claude
@Jonnyton Jonnyton added checker:claude PR requires checker/reviewer from the Claude-family. writer:codex Automated PR was written by a Codex/OpenAI-family model. labels May 6, 2026
@Jonnyton
Copy link
Copy Markdown
Owner Author

Jonnyton commented May 6, 2026

Loop review policy

  • Writer family: Codex
  • Required checker family: Claude

Do not accept this PR with a same-family checker.

@Jonnyton Jonnyton added the checker:claude PR requires checker/reviewer from the Claude-family. label May 6, 2026
@Jonnyton
Copy link
Copy Markdown
Owner Author

Jonnyton commented May 6, 2026

Codex key: HOLD / revision required.

The direction is right: empty provider text should not be treated as successful LLM output, and falling through from an empty API provider to a usable fallback is valuable. But the implementation still has a gap: in ProviderRouter.call, when a local provider returns empty text and all_api_providers_in_cooldown(...) is false, control falls through to the "Successful call" block and returns the empty local response. That can happen when API providers are absent/not registered rather than explicitly cooled down, which is a common daemon shape.

Please add a regression test for local-only / missing-API registry returning empty text, and make every empty response either continue to another provider or fail loudly with diagnostics. After that, this should be mergeable.

@Jonnyton Jonnyton added auto-fix-reviewed Automated writer reached a final no-PR outcome; retry manually if needed. auto-fix-superseded Older auto-change PR was closed because a newer branch superseded it. labels May 8, 2026
@Jonnyton
Copy link
Copy Markdown
Owner Author

Jonnyton commented May 8, 2026

Auto-change PR closed as superseded

This stale-base PR from auto-change/issue-81-codex-25417406236 was superseded by #708 from auto-change/issue-81-codex-25580949514.
The community-loop queue should review the newer PR instead of carrying both branches.

@Jonnyton Jonnyton closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-fix-reviewed Automated writer reached a final no-PR outcome; retry manually if needed. auto-fix-superseded Older auto-change PR was closed because a newer branch superseded it. checker:claude PR requires checker/reviewer from the Claude-family. writer:codex Automated PR was written by a Codex/OpenAI-family model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG-036] Echoes public-source intake smoke run fails on empty LLM response

1 participant