Skip to content

[auto-change] BUG-016: Typed (non-str) output_keys from prompt-template nodes are not actually written to state#560

Closed
Jonnyton wants to merge 1 commit intomainfrom
auto-change/issue-42-codex-25464955498
Closed

[auto-change] BUG-016: Typed (non-str) output_keys from prompt-template nodes are not actually written to state#560
Jonnyton wants to merge 1 commit intomainfrom
auto-change/issue-42-codex-25464955498

Conversation

@Jonnyton
Copy link
Copy Markdown
Owner

@Jonnyton Jonnyton commented May 6, 2026

Fixes #42

Writer family: Codex
Required checker family: Claude

Automated community-loop change produced by the subscription-backed Codex lane.

…te nodes are not actually written to state

Fixes #42

Writer family: Codex

Required checker family: Claude
@Jonnyton
Copy link
Copy Markdown
Owner Author

Jonnyton commented May 6, 2026

Loop review policy

  • Writer family: Codex
  • Required checker family: Claude

Do not accept this PR with a same-family checker.

@Jonnyton Jonnyton added checker:claude PR requires checker/reviewer from the Claude-family. writer:codex Automated PR was written by a Codex/OpenAI-family model. labels May 6, 2026
@Jonnyton
Copy link
Copy Markdown
Owner Author

Jonnyton commented May 6, 2026

Same-family Codex review note, not the required Claude/Cowork checker key.

I reviewed #560 from an isolated worktree after refreshing origin/main. The PR is test-only: it adds tests/test_graph_compiler_typed_outputs.py and does not change runtime code. Focused verification: python -m pytest tests/test_graph_compiler_typed_outputs.py -q -> 1 passed; python -m ruff check tests/test_graph_compiler_typed_outputs.py -> clean.

Design read: this looks like a regression-test closure for BUG-016, not an implementation fix. The test proves the current graph compiler already appends a typed JSON response contract and coerces 7 into integer state value 7 for a typed rating: int output. I am okay with that shape if Cowork/Claude confirms the bug was already fixed by prior graph-compiler work and a test-only close is intentional. If the required checker finds an uncovered variant (multi-output, typed bool/list/dict, or non-JSON fallback), send it back to expand the regression. No merge without Claude/Cowork checker and explicit host approval naming PR #560.

@Jonnyton Jonnyton added auto-fix-reviewed Automated writer reached a final no-PR outcome; retry manually if needed. auto-fix-superseded Older auto-change PR was closed because a newer branch superseded it. labels May 8, 2026
@Jonnyton
Copy link
Copy Markdown
Owner Author

Jonnyton commented May 8, 2026

Auto-change PR closed as superseded

This stale-base PR from auto-change/issue-42-codex-25464955498 was superseded by #705 from auto-change/issue-42-codex-25577216683.
The community-loop queue should review the newer PR instead of carrying both branches.

@Jonnyton Jonnyton closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-fix-reviewed Automated writer reached a final no-PR outcome; retry manually if needed. auto-fix-superseded Older auto-change PR was closed because a newer branch superseded it. checker:claude PR requires checker/reviewer from the Claude-family. writer:codex Automated PR was written by a Codex/OpenAI-family model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG-016] Typed (non-str) output_keys from prompt-template nodes are not actually written to state

1 participant