Conversation
mpariente
reviewed
Dec 16, 2020
Comment on lines
+24
to
+27
| print("It appears that augmented files have already been generated.\n" | ||
| " If the augmentation process went well the first time you ran " | ||
| "generate_librimix.sh please comment out the line relative to" | ||
| " augment_train_noise.py.\nSkipping data augmentation.") |
Collaborator
There was a problem hiding this comment.
Let's not ask to comment the augmentation line. It's more confusing than helping IMO. Just keep the "It appears ... generated. Skipping data augmentation"
mpariente
reviewed
Dec 16, 2020
Collaborator
mpariente
left a comment
mpariente
left a comment
There was a problem hiding this comment.
LGTM, just change the message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #10