Fix: Correct usage of withUnsafeBytes in update(data:) #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation could lead to a dangling pointer issue. The pointer obtained from data.withUnsafeBytes is only guaranteed to be valid for the duration of its closure. By passing the pointer out of the closure to the update(bytes:) function, we risked memory corruption or a crash.
This fix moves the call to update(bytes:) inside the withUnsafeBytes closure, ensuring the pointer is always valid when accessed.
After this fix, we can get the exactly same result with
b3sum:output:
The
b3sum's output: