fix: config dialog made main window unresponsive (BUG-002)#38
fix: config dialog made main window unresponsive (BUG-002)#38JoshCLWren merged 2 commits intomainfrom
Conversation
Two bugs in _show_config(): 1. wm_transient was called on the master window instead of the dialog, making the main window subordinate to the config dialog — it hid behind it and became unresponsive/unclickable. 2. The Close button called dialog.destroy() directly, bypassing on_close(), so _dialog_active was never reset to False. Also replaced the catch-all <Key> binding (which closed the dialog on any keypress, including typing in the color entry) with explicit <Escape>, q, Q bindings. Removed the spurious <Double-Button-1> close binding. Adds regression test: tests/test_bug_002_config_dialog.py Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
wm_transientwas called on the master window instead of the dialog, making the main window subordinate to the config dialog — it hid behind it and became unclickable/unresponsivedialog.destroy()directly, bypassingon_close(), so_dialog_activewas never reset toFalse<Key>binding (closed dialog on any keypress, including typing in the color entry) with explicit<Escape>,q,Qbindings<Double-Button-1>close bindingTest plan
make pytestpasses with 96%+ coveragetests/test_bug_002_config_dialog.pyall green🤖 Generated with Claude Code