Skip to content

fix: config dialog made main window unresponsive (BUG-002)#38

Merged
JoshCLWren merged 2 commits intomainfrom
fix/bug-002-config-dialog-unresponsive
Mar 24, 2026
Merged

fix: config dialog made main window unresponsive (BUG-002)#38
JoshCLWren merged 2 commits intomainfrom
fix/bug-002-config-dialog-unresponsive

Conversation

@JoshCLWren
Copy link
Copy Markdown
Owner

Summary

  • wm_transient was called on the master window instead of the dialog, making the main window subordinate to the config dialog — it hid behind it and became unclickable/unresponsive
  • The Close button called dialog.destroy() directly, bypassing on_close(), so _dialog_active was never reset to False
  • Replaced catch-all <Key> binding (closed dialog on any keypress, including typing in the color entry) with explicit <Escape>, q, Q bindings
  • Removed spurious <Double-Button-1> close binding

Test plan

  • make pytest passes with 96%+ coverage
  • 5 new regression tests in tests/test_bug_002_config_dialog.py all green
  • Manually: open config via right-click → Configuration, verify main window stays visible and interactive behind the dialog
  • Manually: Esc, q, Q all dismiss the config dialog
  • Manually: typing in the background color entry does not close the dialog

🤖 Generated with Claude Code

JoshCLWren and others added 2 commits March 24, 2026 06:23
Two bugs in _show_config():

1. wm_transient was called on the master window instead of the dialog,
   making the main window subordinate to the config dialog — it hid
   behind it and became unresponsive/unclickable.

2. The Close button called dialog.destroy() directly, bypassing
   on_close(), so _dialog_active was never reset to False.

Also replaced the catch-all <Key> binding (which closed the dialog on
any keypress, including typing in the color entry) with explicit
<Escape>, q, Q bindings. Removed the spurious <Double-Button-1>
close binding.

Adds regression test: tests/test_bug_002_config_dialog.py

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 24, 2026

Warning

Rate limit exceeded

@JoshCLWren has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 3 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 89fcf41e-3ef5-4c24-a5df-2c192e9e5c46

📥 Commits

Reviewing files that changed from the base of the PR and between dc9fc4d and 7c39459.

📒 Files selected for processing (3)
  • Makefile
  • cdisplayagain.py
  • tests/test_bug_002_config_dialog.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bug-002-config-dialog-unresponsive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JoshCLWren JoshCLWren merged commit 2c1c19d into main Mar 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant