Skip to content

Fix android translucent flags #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2016
Merged

Fix android translucent flags #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20b0cfb
translucent
May 20, 2016
d68107b
update android optional attributes
May 20, 2016
099adf0
bump ns modules for demo
May 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,9 @@ the `<Slides:SlideContainer>` element also has a property called `loop` which is

the `<Slides:SlideContainer>` element also has a property called `interval` which is a integer value and the value is in milliseconds. The suggested use case would be for a Image Carousel or something of that nature which can change the image for every fixed intervals. In unloaded function call `page.getViewById("your_id").stopSlideshow()` to unregister it (your_id is the id given to `<Slides:SlideContainer>`), it can be restarted with `startSlidShow`.

#### Android Optional Attribute
- `AndroidTransparentStatusBar`: boolean - If true, the Android status bar will be transparent on devices that support it. Typically this is API >=21 (Lollipop).
#### Android Optional Attributes
- `androidTranslucentStatusBar`: boolean - If true, the Android status bar will be translucent on devices that support it. (Android sdk >= 19).
- `androidTranslucentNavBar`: boolean - If true, the Android navigation bar will be translucent on devices that support it. (Android sdk >= 19).

###Plugin Development Work Flow:

Expand Down
46 changes: 23 additions & 23 deletions demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
{
"nativescript": {
"id": "org.nativescript.demo",
"tns-android": {
"version": "2.0.0"
},
"tns-ios": {
"version": "2.0.0"
}
},
"dependencies": {
"nativescript-slides": "file:..",
"tns-core-modules": "2.0.0"
},
"devDependencies": {
"babel-traverse": "6.9.0",
"babel-types": "6.9.0",
"babylon": "6.8.0",
"filewalker": "0.1.2",
"lazy": "1.0.11",
"nativescript-dev-typescript": "^0.3.1",
"typescript": "^1.8.7"
}
}
"nativescript": {
"id": "org.nativescript.demo",
"tns-android": {
"version": "2.0.0"
},
"tns-ios": {
"version": "2.0.0"
}
},
"dependencies": {
"nativescript-slides": "file:..",
"tns-core-modules": "^2.0.1"
},
"devDependencies": {
"babel-traverse": "6.9.0",
"babel-types": "6.9.0",
"babylon": "6.8.0",
"filewalker": "0.1.2",
"lazy": "1.0.11",
"nativescript-dev-typescript": "^0.3.1",
"typescript": "^1.8.7"
}
}
7 changes: 5 additions & 2 deletions nativescript-slides.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,13 @@ export declare class SlideContainer extends AbsoluteLayout {
private _pageWidth;
private _loop;
private _interval;
private _AndroidTransparentStatusBar;
private _androidTranslucentStatusBar;
private _androidTranslucentNavBar;
private timer_reference;
interval: number;
loop: boolean;
AndroidTransparentStatusBar: boolean;
androidTranslucentStatusBar: boolean;
androidTranslucentNavBar: boolean;
pageWidth: number;
android: any;
ios: any;
Expand All @@ -31,6 +33,7 @@ export declare class SlideContainer extends AbsoluteLayout {
startSlideshow(): void;
nextSlide(): void;
previousSlide(): void;
resetAndroidTranslucentFlags(): void;
private setupLeftPanel();
private setupRightPanel();
private applySwipe(pageWidth);
Expand Down
48 changes: 38 additions & 10 deletions nativescript-slides.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import * as AnimationModule from 'ui/animation';
import * as gestures from 'ui/gestures';
import {AnimationCurve} from 'ui/enums';

const LayoutParams = android.view.WindowManager.LayoutParams;

Copy link
Owner

@JoshDSommer JoshDSommer May 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my android d.ts file doesn't have layoutParams, did you get yours from tns-platform-declarations... I think i'm behind.

Copy link
Contributor Author

@bradmartin bradmartin May 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have it. But it won't have all the flags since it's API 17 and these
are 19.

On Fri, May 20, 2016, 5:56 AM Josh Sommer notifications@github.com wrote:

In nativescript-slides.ts
#9 (comment)
:

@@ -9,6 +9,8 @@ import * as AnimationModule from 'ui/animation';
import * as gestures from 'ui/gestures';
import {AnimationCurve} from 'ui/enums';

+const LayoutParams = android.view.WindowManager.LayoutParams;
+

my android d.ts file doesn't have layoutParams, did you get yours from
tns-platform-declarations... I think i'm behind.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/TheOriginalJosh/nativescript-slides/pull/9/files/099adf0c594cdfe550436750e558ced1a94f81c1#r64023394

Copy link
Contributor Author

@bradmartin bradmartin May 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also won't have clearFlags() that was after android 17

On Fri, May 20, 2016, 6:37 AM Brad Martin bradwaynemartin@gmail.com wrote:

Should have it. But it won't have all the flags since it's API 17 and
these are 19.

On Fri, May 20, 2016, 5:56 AM Josh Sommer notifications@github.com
wrote:

In nativescript-slides.ts
#9 (comment)
:

@@ -9,6 +9,8 @@ import * as AnimationModule from 'ui/animation';
import * as gestures from 'ui/gestures';
import {AnimationCurve} from 'ui/enums';

+const LayoutParams = android.view.WindowManager.LayoutParams;
+

my android d.ts file doesn't have layoutParams, did you get yours from
tns-platform-declarations... I think i'm behind.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/TheOriginalJosh/nativescript-slides/pull/9/files/099adf0c594cdfe550436750e558ced1a94f81c1#r64023394

export class Slide extends StackLayout { }

enum direction {
Expand All @@ -31,7 +33,8 @@ export class SlideContainer extends AbsoluteLayout {
private _pageWidth: number;
private _loop: boolean;
private _interval: number;
private _AndroidTransparentStatusBar: boolean;
private _androidTranslucentStatusBar: boolean;
private _androidTranslucentNavBar: boolean;
private timer_reference: number;

get interval() {
Expand All @@ -50,12 +53,20 @@ export class SlideContainer extends AbsoluteLayout {
this._loop = value;
}

get AndroidTransparentStatusBar() {
return this._AndroidTransparentStatusBar;
get androidTranslucentStatusBar() {
return this._androidTranslucentStatusBar;
}

set androidTranslucentStatusBar(value: boolean) {
this._androidTranslucentStatusBar = value;
}

set AndroidTransparentStatusBar(value: boolean) {
this._AndroidTransparentStatusBar = value;
get androidTranslucentNavBar() {
return this._androidTranslucentNavBar;
}

set androidTranslucentNavBar(value: boolean) {
this._androidTranslucentNavBar = value;
}

get pageWidth() {
Expand Down Expand Up @@ -93,12 +104,19 @@ export class SlideContainer extends AbsoluteLayout {
if (!this._loaded) {
this._loaded = true;

// Android Transparent Status Bar
if (this.AndroidTransparentStatusBar === true && app.android && Platform.device.sdkVersion >= '21') {
const View = android.view.View;
// Android Translucent bars API >= 19 only
if (this.androidTranslucentStatusBar === true || this._androidTranslucentNavBar === true && app.android && Platform.device.sdkVersion >= '19') {
let window = app.android.startActivity.getWindow();
// set the status bar to Color.Transparent
window.setStatusBarColor(0x000000);

// check for status bar
if (this._androidTranslucentStatusBar === true) {
window.addFlags(LayoutParams.FLAG_TRANSLUCENT_STATUS);
}

// check for nav bar
if (this._androidTranslucentNavBar === true) {
window.addFlags(LayoutParams.FLAG_TRANSLUCENT_NAVIGATION);
}
}

let slides: StackLayout[] = [];
Expand Down Expand Up @@ -172,6 +190,16 @@ export class SlideContainer extends AbsoluteLayout {
});
}

public resetAndroidTranslucentFlags(): void {
if (this._androidTranslucentStatusBar === true) {
let window = app.android.startActivity.getWindow();
window.clearFlags(LayoutParams.FLAG_TRANSLUCENT_STATUS);
Copy link
Owner

@JoshDSommer JoshDSommer May 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this let window but up two lines or is window already available I'm getting a compiler error here.

}
if (this._androidTranslucentNavBar === true) {
window.clearFlags(LayoutParams.FLAG_TRANSLUCENT_NAVIGATION);
}
}

private setupLeftPanel(): void {
this.direction = direction.none;
this.transitioning = false;
Expand Down