Conversation
These classes do not have assertion checks. Without such checks, programmer errors that violate hidden assumptions may go unnoticed during development, potentially leading to subtle bugs. Add assertion statements to key constructors and logic points to ensure that critical internal assumptions always hold, such as non-null fields, object type consistency, and task list size/count invariants. Assertions are used together with exceptions to cover all bases: Assertions for programmer errors, and exceptions for user errors. This will improve code robustness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These classes do not have assertion checks.
Without such checks, programmer errors that violate hidden assumptions may go unnoticed during development, potentially leading to subtle bugs.
Add assertion statements to key constructors and logic points to ensure that critical internal assumptions always hold, such as non-null fields, object type consistency, and task list size/count invariants.
Assertions are used together with exceptions to cover all bases: Assertions for programmer errors, and exceptions for user errors. This will improve code robustness.