fix(installer): add .github/workflows/ and mcp-servers/ to FrameworkFiles#197
Merged
JoshLuedeman merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
…iles Both directories were silently skipped during install/update: - .github/workflows/ — excluded teamwork-ci.yaml.example (added v1.2.0, #59) - mcp-servers/ — excluded all 5 Python MCP servers (added v1.1.0) Update TestIsFrameworkFile_Excluded to remove the now-valid .github/workflows/ci.yaml case, and extend the coverage test to assert both new prefixes are present. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two framework directories were silently excluded during
teamwork init/teamwork updatebecause they were missing from theFrameworkFilesallowlist ininternal/installer/installer.go..github/workflows/teamwork-ci.yaml.example— the GitHub Actions CI template added in v1.2.0 (#59)mcp-servers/Both are documented as part of the framework (
docs/mcp.md, CHANGELOG v1.1.0 / v1.2.0) but were never actually installed in target repositories.Fix
.github/workflows/andmcp-servers/toFrameworkFilesTestIsFrameworkFile_Excluded— remove the now-incorrect assertion that.github/workflows/ci.yamlis excludedTestFrameworkFiles_IncludesScriptsAndMakefileto assert both new prefixes are presentTesting
All existing installer tests pass. New assertions confirm the two prefixes are present in
FrameworkFilesand thatisFrameworkFilereturnstruefor paths under them.