Closed
Conversation
- Fix method typo getWorkerDefult -> getWorkerDefault (laravel#49) - Fix InstanceDelete returning integer 1 instead of self::FAILURE (laravel#85) - Fix AuthToken --remove crashing with empty token list (laravel#86) - Fix DatabaseDelete catching Throwable instead of RequestException (laravel#46) - Add missing --json option to CacheDelete and BucketDelete (laravel#48) - Add non-interactive defaults for DomainCreate wildcard and verification (laravel#45) - Fix DatabaseOpen leaking plaintext credentials to terminal (laravel#83) - Remove 28 lines of commented-out code in EnvironmentVariables (laravel#84) - Fix wrong RequestException import (Illuminate vs Saloon) in 7 commands (laravel#50) - Add error handling for ApplicationUpdate API failures (laravel#51) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Test InstanceDelete returns FAILURE on API error (laravel#85) - Test AuthToken --remove with empty token list (laravel#86) - Test DatabaseDelete succeeds without swallowing CommandExitException (laravel#46) - Test CacheDelete accepts --json option (laravel#48) - Test BucketDelete accepts --json option (laravel#48) - Test ApplicationUpdate shows error on API failure (laravel#51) - Test BackgroundProcessCreate method name is getWorkerDefault (laravel#49) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
All 10 issues already covered by existing upstream PRs: laravel#42, laravel#52, laravel#87, laravel#90, and others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 9 bugs reported in the laravel/cloud-cli issue tracker, affecting 16 command files:
getWorkerDefulttogetWorkerDefaultin BackgroundProcessCreate (22 references)RequestExceptionimport (Illuminate vs Saloon) in 7 delete/verify commands: ApplicationDelete, BackgroundProcessDelete, DatabaseClusterDelete, DomainDelete, DomainVerify, EnvironmentDelete, InstanceDeleteApplicationUpdateAPI failures (try/catch around update and avatar upload)InstanceDeletereturning integer1instead ofself::FAILUREconstantAuthToken --removeagainst empty token list (early return instead of callingselect()with empty options)DatabaseDeletecatchingThrowable(swallowsCommandExitException) — narrowed toRequestException--jsonoption toCacheDeleteandBucketDeletesignaturesDomainCreatewildcard_enabled (false) and verification_method (pre_verification)DatabaseOpenleaking plaintext connection URL (username/password) to terminal outputEnvironmentVariablesTest plan
--memory-limit=512M)🤖 Generated with Claude Code