[11.x] Fix sub-minute scheduling skips at minute boundaries#18
Open
JoshSalway wants to merge 1 commit into11.xfrom
Open
[11.x] Fix sub-minute scheduling skips at minute boundaries#18JoshSalway wants to merge 1 commit into11.xfrom
JoshSalway wants to merge 1 commit into11.xfrom
Conversation
The repeatEvents() method called endOfMinute() on startedAt directly, which mutated the Carbon instance. This caused the boundary to shift on each iteration, leading to skipped executions. Using copy() before endOfMinute() preserves the original timestamp. Also adds an early return if the minute boundary is crossed mid-iteration. Fixes laravel#57070 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repeatEvents()calledendOfMinute()directly on$this->startedAt, mutating the Carbon instancecopy()->endOfMinute()to preserve the original timestamp, and adds an early return guard if the minute boundary is crossed mid-iterationRelated Issue
Fixes laravel#57070
Test plan
🤖 Generated with Claude Code