chore: add common createParseConfigHost function#2056
chore: add common createParseConfigHost function#2056rubiesonthesky merged 2 commits intoJoshuaKGoldberg:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
+ Coverage 74.80% 75.09% +0.29%
==========================================
Files 177 177
Lines 7590 7554 -36
Branches 1063 1058 -5
==========================================
- Hits 5678 5673 -5
+ Misses 1907 1876 -31
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| getDirectories: ts.sys.getDirectories, | ||
| // eslint-disable-next-line @typescript-eslint/unbound-method | ||
| readDirectory: ts.sys.readDirectory, | ||
| // eslint-disable-next-line @typescript-eslint/unbound-method |
There was a problem hiding this comment.
At this point I'd say just disable it in the file 😄
Is there a tracking TS issue for correcting their typedefs? If not, up for filing one? This comes up once in a while...
There was a problem hiding this comment.
Fixing this :D
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
⚡ Love the reduction in dependencies & overall line count, nice!
Just requesting one dedup of ESLint inline config comments, otherwise no complaint from me.
|
🎉 This is included in version v0.8.5 🎉 The release is available on: Cheers! 📦🚀 |
|
This actually fixed #1522 |
2 participants
PR Checklist
status: accepting prsOverview
There is not a own task about this, because it was split out from another PR.
Adds common createParseConfigHost function to be used with
ts.parseJsonConfigFileContent.minimatchis no longer needed, and thus it's been uninstalled.