Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Simplifies the extensions type for blockESLint to no longer allow strings, and to require that objects have files. This way all plugins/rules entries are scoped to specific files.

As a nice side effect, sorting of groups is a little simpler. It's "just" an alphabetical sort of the targeted files. See the new processForSort.

🎁

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (7891011) to head (06ed6f5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
+ Coverage   98.59%   98.62%   +0.03%     
==========================================
  Files         137      139       +2     
  Lines         922      944      +22     
  Branches      235      245      +10     
==========================================
+ Hits          909      931      +22     
  Misses          9        9              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9e97d56 into main Dec 2, 2025
12 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-files branch December 2, 2025 22:13
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

🎉 This is included in version v2.52.0 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg added a commit that referenced this pull request Dec 2, 2025
## PR Checklist

- [x] Addresses an existing open issue: fixes #2271
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Finishes the work in #2288 and builds off the new ESLint `files`
extension structure in #2291.

Alas, due to
eslint-community/eslint-plugin-n#472,
`n/no-unpublished-bin` has to be manually disabled.

🎁
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Move all ESLint settings to files-specific blocks

2 participants