Skip to content

Add --no-reset option to the list command#91

Merged
Josverl merged 2 commits into
mainfrom
copilot/add-no-reset-option
May 20, 2026
Merged

Add --no-reset option to the list command#91
Josverl merged 2 commits into
mainfrom
copilot/add-no-reset-option

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 19, 2026

mpflash list unconditionally reset every connected board after listing, with no way to suppress it. This adds a --reset/--no-reset flag (default: --reset) so the reset step can be skipped.

Changes

  • mpflash/cli_list.py — added --reset/--no-reset click option; wraps the per-board reset loop in if reset: guard
  • tests/cli/test_cli_list.py — added parametrized cases for both --reset and --no-reset

Usage

# skip resetting boards after listing (useful for debugging)
mpflash list --no-reset

Copilot AI linked an issue May 19, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Add --no-reset option to list command Add --no-reset option to the list command May 19, 2026
Copilot AI requested a review from Josverl May 19, 2026 23:13
@Josverl Josverl marked this pull request as ready for review May 20, 2026 00:15
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.56%. Comparing base (c5bed8f) to head (8b6bfa1).

Files with missing lines Patch % Lines
mpflash/cli_list.py 33.33% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   75.55%   75.56%   +0.01%     
==========================================
  Files          54       54              
  Lines        3031     3033       +2     
  Branches      488      489       +1     
==========================================
+ Hits         2290     2292       +2     
  Misses        621      621              
  Partials      120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Josverl Josverl merged commit 08fbc44 into main May 20, 2026
32 of 33 checks passed
@Josverl Josverl deleted the copilot/add-no-reset-option branch May 20, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a --no-reset option to the list command

2 participants