Skip to content

handle case where normal peer sends a piece before joystream peer #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mnaamani wants to merge 1 commit into from
Closed

handle case where normal peer sends a piece before joystream peer #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions sources/src/TorrentPlugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,22 +735,27 @@ protocol_session::RemovedConnectionCallbackHandler<libtorrent::peer_id> TorrentP
protocol_session::FullPieceArrived<libtorrent::peer_id> TorrentPlugin::fullPieceArrived() {

return [this](const libtorrent::peer_id & peerId, const protocol_wire::PieceData & pieceData, int index) -> void {

// Make sure no outstanding calls exist for this index
assert(!_outstandingFullPieceArrivedCalls.count(index));

_outstandingFullPieceArrivedCalls[index] = peerId;

// Tell libtorrent to validate piece
// last argument is a flag which presently seems to only test
// flags & torrent::overwrite_existing, which seems to be whether
// the piece should be overwritten if it is already present
//
// libtorrent::torrent_plugin::on_piece_pass()
// libtorrent::torrent_plugin::on_piece_failed()
// processes result of checking

torrent()->add_piece(index, pieceData.piece().get(), 0);
if (!torrent()->have_piece(index)) {
// Make sure no outstanding calls exist for this index
assert(!_outstandingFullPieceArrivedCalls.count(index));

_outstandingFullPieceArrivedCalls[index] = peerId;

// Tell libtorrent to validate piece
// last argument is a flag which presently seems to only test
// flags & torrent::overwrite_existing, which seems to be whether
// the piece should be overwritten if it is already present
//
// libtorrent::torrent_plugin::on_piece_pass()
// libtorrent::torrent_plugin::on_piece_failed()
// processes result of checking
torrent()->add_piece(index, pieceData.piece().get(), 0);
} else {
// We already received the piece from another peer (most likely a non joystream peer)
// For now we ignore the validity of the piece data
// tell session about endpoint and piece
_session.validPieceReceivedOnConnection(peerId, index);
}
};
}

Expand Down