-
Notifications
You must be signed in to change notification settings - Fork 3
Protocol upgrade pipelining #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bedeho
merged 12 commits into
JoystreamClassic:development
from
mnaamani:protocol-upgrade-pipelining
Feb 2, 2018
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
be25e61
handle case where normal peer sends a piece before joystream peer
mnaamani aee4860
Add AllSellersGone event and protocol session AllSellersGone callback…
mnaamani 9404169
Add AllSellersGone event and protocol session AllSellersGone callback…
mnaamani b945d7d
Merge branch 'fix-paid-download' into protocol-upgrade-pipelining
mnaamani 05a4e4c
drop connections if protocol major versions are different
mnaamani bbc0665
synchronously validate full piece when received from seller
mnaamani 39491aa
remove binding of loadPiece to specific peer
mnaamani 0b5b920
bump version to 0.2.0, update dependencies for protocol upgrade
mnaamani 1c671bb
disconnect slow sellers when buying
mnaamani b1e4697
don't ban timed out peers
mnaamani 45e5a9a
let Buyer session handle disconnecting timedout sellers
mnaamani 5875164
calculate max time to service piece when going to buy mode
mnaamani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a bit strict, its not clear that we cannot hold a connection open for normal bittorrent/DHT traffic. It could also be useful for the extension user to understand how often and what peers are using incompatible protocol version. To this end, one could introduce a new enum value in
BEPSupportStatuswhich reflects an incompatible version explicitly. For now though, this is good enough I think, so at best making an issue out of this could be interesting, and perhaps marking it with "good first issue" or help wanted.