refactor peer management#46
refactor peer management#46mnaamani merged 8 commits intoJoystreamClassic:developmentfrom mnaamani:refactor-peer-management
Conversation
…erts, add missing alert
…erplugin added/removed alerts
| TorrentInfo: Libtorrent.TorrentInfo, | ||
| Session, | ||
| StateT | ||
| StateT, |
There was a problem hiding this comment.
StateT is mentioned twice here. We can maybe only keep line 18 TORRENT_STATE: StateT ?
There was a problem hiding this comment.
Yes good point, I think I didn't wan't to totally break any code in electron app that was still depending on StateT, and would remove it after refactoring.
There was a problem hiding this comment.
Better yet, the StateT.js itself should be removed, and have the native addon expose the enumerations for the torrent state, as we have done for other enumerations to make sure they are always correct if changed in c++
There was a problem hiding this comment.
This PR should expose the enumeration for the torrent state : JoystreamClassic/libtorrent-node#15
I have also change the method name to work with the standard that we are using encode/decode instead of createValue/fromValue old name.
2 participants
Uh oh!
There was an error while loading. Please reload this page.