Skip to content

Assisted peer discovery#86

Merged
bedeho merged 5 commits intoJoystreamClassic:developmentfrom
mnaamani:assisted-peer-discovery
Oct 4, 2017
Merged

Assisted peer discovery#86
bedeho merged 5 commits intoJoystreamClassic:developmentfrom
mnaamani:assisted-peer-discovery

Conversation

@mnaamani
Copy link
Copy Markdown
Collaborator

@mnaamani mnaamani commented Oct 4, 2017

A few improvements and bug fixes over #85

  • Adjusted announcement interval to be more frequent (2 minutes), (down from 15 minutes)
  • Separate intervals for announcement and getting peers
  • Get peers when torrent is added
  • Fix call to announce on torrent added which was announcing wrong port undefined

@mnaamani
Copy link
Copy Markdown
Collaborator Author

mnaamani commented Oct 4, 2017

While working on this I realized that the port being announce in the DHT announcement message is the session.listenPort() which is the local network port. If we are behind a NAT router we want to announce our publicly mapped port which can be obtained in the portmap_alert http://www.libtorrent.org/reference-Alerts.html#portmap-alert

bedeho
bedeho approved these changes Oct 4, 2017
View reviewed changes
Copy link
Copy Markdown

@bedeho bedeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@bedeho bedeho merged commit 1592603 into JoystreamClassic:development Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedeho bedeho bedeho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnaamani @bedeho @rllola