allow schema types to be pluggable #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
requested changes
Jan 17, 2017
Collaborator
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
Thanks for this. It makes a lot of sense to do it this way. The only change is to improve maintainability in the future and simplicity for the end-user.
README.md
Outdated
| end | ||
| end | ||
|
|
||
| JsonApiClient::Schema::TypeFactory.register money: MyMoneyCaster |
Collaborator
There was a problem hiding this comment.
Small change: having the users register on the TypeFactory class locks to this implementation. It'll most likely remain this way, but it might make more sense for the developer to call .register on the Schema class/module instead. If for whatever reason, we want to rename the TypeFactory class or refactor it, we need to keep that constant around. Internally, JsonApiClient::Schema.register could just delegate to JsonApiclient::Schema::TypeFactory
this refactoring allows developers to add support of new schema types
Fivell
force-pushed
the
type_casting_refactoring
branch
from
d535d55 to
724875d
Compare
Contributor
Author
|
@chingor13 , done! |
chingor13
approved these changes
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this refactoring allows developers to add support of new schema types